BLT-1047: adding ability to customize paths for phpunit tests. #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8015ab6 to
f8de9bd
Compare
d5971ae to
abbd1a3
Compare
grasmash
reviewed
Apr 25, 2017
readme/testing.md
Outdated
|
|
||
| ### Configuration | ||
|
|
||
| You can [customize the configuration values](extending-blt.md#modifying-blt-configuration) for the phpunit key. Each should containn a path (to a phpunit test or directory that contains at least one test) and a config path (if custom configuration or boostrapping of Drupal is required): |
There was a problem hiding this comment.
You can customize the tests:phpunit command by modifying the customize the configuration values for the phpunit key.
Each row under the phpunit key should contain a path and a config key. The path key indicates a directory containing PHPUnit tests. The optional config key can be used to specify a PHP configuration file.
03aa982 to
dc253f0
Compare
grasmash
suggested changes
Apr 26, 2017
phing/build.yml
Outdated
| @@ -127,6 +127,13 @@ phpcbf: | |||
| - files.php.custom.themes | |||
| - files.frontend.custom.themes | |||
|
|
|||
| phpunit: | |||
| - path: '{$repo.root}/tests/phpunit}' | |||
There was a problem hiding this comment.
Why are there braces in the path?
There was a problem hiding this comment.
I'd expect $repo.root}/tests/phpunit to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1047 .
Changes proposed: