BLT-1304: Fixes #1304 default no cache setting for SAML. #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greylabel
reviewed
Apr 4, 2017
| @@ -21,8 +21,13 @@ | |||
| // Change these for your installation | |||
| $config['secretsalt'] = 'y0h9d13pki9qdhfm3l5nws4jjn55j6hj'; | |||
| $config['auth.adminpassword'] = 'mysupersecret'; | |||
| // Prevent Varnish from interfering with SimpleSAMLphp. | |||
| setcookie('NO_CACHE', '1'); | |||
There was a problem hiding this comment.
@kylebrowning I remember at one point seeing requests to /saml_login/* being cached unintentionally in Varnish and causing issue. Have we verified removing this works as expected? The NO_CACHE cookie could also be scoped to a specific path.
There was a problem hiding this comment.
@greylabel Yes it could! If thats the case, maybe we should do that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1304
Changes proposed: