Support ACSF vanity domains. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damontgomery and @kylebrowning I think you wrote this alias template originally if you want to comment. You can see it in action on the project you've been helping me on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many projects will have vanity domains for environments, such as
dev.example.cominstead ofexample.dev-project.acsitefactory.com. The current ACSF alias template doesn't support these vanity domains, which causes confusion at best and blockers/bugs at worst (if you are using trusted host patterns or have a temperamental cache).This supports adding vanity domains, and also provides backwards compatibility when vanity domains don't exist.