Fixing PHPCS filset reference. #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JS and CSS code can be sniffed via PHPCS using Drupal coding standards. |
|
Ah ha, interesting. Should this have both lines then? Shouldn't |
|
Yes I think that's right! |
|
Updated. Thanks @grasmash. |
grasmash
reviewed
Feb 13, 2017
phing/build.yml
Outdated
| @@ -91,7 +91,8 @@ phpcs: | |||
| filesets: | |||
| - files.php.custom.modules | |||
| - files.php.tests | |||
| - files.frontend.custom.themes | |||
| - files.php.custom.themes | |||
| - files.frontend.custom.theme | |||
There was a problem hiding this comment.
Looks like you accidentally removed the s.
There was a problem hiding this comment.
Doh! Fixing now. Gotta love Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is correct, but it seems like build.yml has a mistake referencing a fileset for code sniffing. The
files.frontend.custom.themesfileset contains javascript, bower, npm, etc. files, not PHP code. Seems odd to send that through code sniffing. Should this be thefiles.php.custom.themesfileset instead?