Add multisite support for setup tasks #1005
Closed
+547
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasmash
reviewed
Jan 23, 2017
phing/tasks/properties.xml
Outdated
| <available file="${blt.config-dirs.sites}"/> | ||
| <then> | ||
| <!-- Build the site list from *.yml files in the blt/sites directory. --> | ||
| <exec dir="${blt.config-dirs.sites}" command="ls *.yml | tr -d '\n' | sed s/\.yml/,/g" outputProperty="multisite.names"/> |
There was a problem hiding this comment.
I think we may need a more blt-specific pattern, since this could pick up unrelated yml files. Perhaps project.site.yml.
|
Thanks for breaking this into something smaller. I think that the last step before merging is to ensure that there's some type of test coverage. Perhaps we can add a default project.site.yml to a directory during BLT's .travis.yml execution and assert that it has been parsed and generated the expected settings files. |
|
👍 |
|
@grasmash - I've put some additional testing in place here. I wasn't entirely sure how to go about testing that site properties are being correctly parsed, but take a look at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses aspects of #799.
Changes proposed: