Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate / allow overrides of .htaccess for SSL and SAML #608

Closed
danepowell opened this issue Oct 29, 2016 · 6 comments
Closed

Automate / allow overrides of .htaccess for SSL and SAML #608

danepowell opened this issue Oct 29, 2016 · 6 comments
Assignees
Labels
Enhancement A feature or feature request

Comments

@danepowell
Copy link
Contributor

As part of #602 we added sample patches to add SSL and SAML support to .htaccess. I thought these worked at the time, but now it seems like they aren't working. I suspect it's because drupal-scaffold doesn't support patching these files: drupal-composer/drupal-scaffold#45

I think we should remove the sample patches, and somehow work with drupal-scaffold to patch .htaccess and keep it from being clobbered on updates.

@danepowell
Copy link
Contributor Author

cc @aweingarten

@grasmash
Copy link
Contributor

grasmash commented Nov 4, 2016

You can instruct Drupal Scaffold to ignore certain files:

{
  "extra": {
    "drupal-scaffold": {
      "excludes": [
        ".htaccess"
      ]
    }
  }
}

@danepowell
Copy link
Contributor Author

It sounds like we'd have to add that ignore and then patch the file somehow outside of Composer. The challenge would be keeping it in sync with whatever Drupal core version is in use on the project.

@mike-potter
Copy link

I recommend updating the README file to reflect the fact that this is not working. As mentioned in #483 the instructions and link for using external patch files in the README is wrong anyway and doesn't actually explain how to add files in ./patches to composer.json.

@danepowell
Copy link
Contributor Author

danepowell commented Mar 8, 2017

@grasmash @mike-potter thanks for the feedback, please review the changes in #1157 and let me know what you think.

I think that's sufficient to close this issue.

@grasmash
Copy link
Contributor

grasmash commented Mar 9, 2017

@mike-potter Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

3 participants