Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to BLT 9.x Loses Composer Dependencies #2742

Closed
mikemadison13 opened this issue Apr 17, 2018 · 3 comments
Closed

Updating to BLT 9.x Loses Composer Dependencies #2742

mikemadison13 opened this issue Apr 17, 2018 · 3 comments
Assignees
@mikemadison13
Labels
Bug Something isn't working

Comments

@mikemadison13
Copy link
Contributor

My system information:

  • Operating system type: Mac OS
  • Operating system version: 10.11.6
  • BLT version: 9.x-dev

Output of blt doctor:

blt doctor
+---------------------------+------------------------------------------------------------+
| Property                  | Value                                                      |
+---------------------------+------------------------------------------------------------+
| %paths.%root              | /var/www/capitalcamp/docroot                               |
| %paths.%site              | sites/default                                              |
| %paths.%modules           | sites/all/modules                                          |
| %paths.%themes            | sites/all/themes                                           |
| %paths.%config-sync       | /var/www/capitalcamp/config/default                        |
| %paths.%files             | sites/default/files                                        |
| %paths.%temp              | /tmp                                                       |
| %paths.%private           | /var/www/capitalcamp/files-private                         |
| admin-theme               | seven                                                      |
| alias-searchpaths.0       | /var/www/capitalcamp/drush/sites                           |
| blt-version               | 9.0.5                                                      |
| bootstrap                 | Successful                                                 |
| composer-version          | Composer version 1.6.3 2018-01-31 16:28:17                 |
| config-sync               | /var/www/capitalcamp/config/default                        |
| db-driver                 | mysql                                                      |
| db-hostname               | localhost                                                  |
| db-name                   | drupal                                                     |
| db-password               | drupal                                                     |
| db-port                   | 3306                                                       |
| db-status                 | Connected                                                  |
| db-username               | drupal                                                     |
| drupal-settings-file      | sites/default/settings.php                                 |
| drupal-version            | 8.5.1                                                      |
| drush-alias-files.0       | /var/www/capitalcamp/drush/sites/capitalcamp.site.yml      |
| drush-alias-files.1       | /var/www/capitalcamp/drush/sites/example.acsf.site.yml     |
| drush-alias-files.2       | /var/www/capitalcamp/drush/sites/example.local.site.yml    |
| drush-conf.0              | /var/www/capitalcamp/vendor/drush/drush/drush.yml          |
| drush-conf.1              | /var/www/capitalcamp/drush/drush.yml                       |
| drush-conf.2              | /var/www/capitalcamp/docroot/sites/default/local.drush.yml |
| drush-script              | /var/www/capitalcamp/vendor/bin/drush                      |
| drush-temp                | /tmp                                                       |
| drush-version             | 9.2.3                                                      |
| files                     | sites/default/files                                        |
| install-profile           | lightning                                                  |
| modules                   | sites/all/modules                                          |
| php-bin                   | /usr/bin/php7.1                                            |
| php-conf.0                | /etc/php/7.1/cli/php.ini                                   |
| php-os                    | Linux                                                      |
| private                   | /var/www/capitalcamp/files-private                         |
| root                      | /var/www/capitalcamp/docroot                               |
| site                      | sites/default                                              |
| stacks.drupal-vm.inited   | true                                                       |
| stacks.dev-desktop.inited | false                                                      |
| temp                      | /tmp                                                       |
| theme                     | twentyeighteen                                             |
| themes                    | sites/all/themes                                           |
| uri                       | http://local.capitalcamp.com                               |
+---------------------------+------------------------------------------------------------+
+--------------------------------------+---------------------------+
| Check                                | Problem                   |
+--------------------------------------+---------------------------+
| NodeCheck:checkNodeVersionFileExists | .node-version file exists |
+--------------------------------------+---------------------------+

When I run this command:

composer update

And I expected this to happen:
After running composer update, I do not have certain key dependencies from BLT (most notably dmore/behat-chrome-extension and config_split). I have to manually add these items to my project's composer.json to resolve the problem. see codebase here: Drupal4Gov/Drupal-GovCon-2017#636
@mikemadison13 mikemadison13 added Bug Something isn't working 9.0.x labels Apr 17, 2018
@mikemadison13
Copy link
Contributor Author

here is the update process:

composer update
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 5 installs, 2 updates, 2 removals
  - Removing pear/console_table (v1.3.1)
  - Removing asm89/twig-lint (1.0.2)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing sarciszewski/php-future (0.4.2): Loading from cache
  - Installing acquia/http-hmac-php (3.4.0): Loading from cache
  - Installing typhonius/acquia-php-sdk-v2 (1.0.2): Loading from cache
  - Installing symfony/twig-bridge (v3.4.8): Loading from cache
  - Installing chi-teck/drupal-code-generator (1.23.2): Loading from cache
  - Updating drush/drush (8.1.16 => 9.2.3): Loading from cache
  - Removing acquia/blt (8.9.14)
  - Installing acquia/blt (9.x-dev fd2bb7c): Cloning fd2bb7cf94 from cache
acquia/http-hmac-php suggests installing silex/silex (~1.3.0)
acquia/http-hmac-php suggests installing symfony/security (~3.0.0)
symfony/twig-bridge suggests installing symfony/asset (For using the AssetExtension)
symfony/twig-bridge suggests installing symfony/expression-language (For using the ExpressionExtension)
symfony/twig-bridge suggests installing symfony/form (For using the FormExtension)
symfony/twig-bridge suggests installing symfony/security (For using the SecurityExtension)
symfony/twig-bridge suggests installing symfony/stopwatch (For using the StopwatchExtension)
symfony/twig-bridge suggests installing symfony/templating (For using the TwigEngine)
symfony/twig-bridge suggests installing symfony/web-link (For using the WebLinkExtension)
Writing lock file
Generating autoload files
Updating BLT templated files...
 > blt update --ansi -y
Copying files from BLT's template into your project...
Merging BLT's blt.yml template with your project's blt/blt.yml...
The following BLT updates are outstanding:
 - update_9000000: Convert Drush 8 files to Drush 9.
 - update_9001000: Add deployment_identifier to project .gitignore and re-syncs ci.blt.yml.

Executing updates...
-> update_9000000: Convert Drush 8 files to Drush 9.

 BLT attempted to upgrade your project-specific drush aliases. Please review and manually convert any that remain. 
 BLT configuration files have been renamed.                                                                        

-> update_9001000: Add deployment_identifier to project .gitignore and re-syncs ci.blt.yml.

 .gitignore has been updated. Review it for any custom changes that may have been overwritten. 


 blt/ci.blt.yml has been updated. Review it for any custom changes that may have been overwritten. 

Removing deprecated files and directories...
> blt:init:shell-alias
The BLT alias is already installed and up to date.
> PhantomInstaller\Installer::installPhantomJS
   - PhantomJS v2.1.1 is already installed. Skipping the installation.
rmacbookpro-mikemadison:Drupal-GovCon-2017 mike.madison$ rm composer.lock
macbookpro-mikemadison:Drupal-GovCon-2017 mike.madison$ composer update
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 0 updates, 0 removals
Writing lock file
Generating autoload files
Copying /Users/mike.madison/git/Drupal-GovCon-2017/vendor/acquia/blt/composer.required.json to /Users/mike.madison/git/Drupal-GovCon-2017/blt/composer.required.json
Copying /Users/mike.madison/git/Drupal-GovCon-2017/vendor/acquia/blt/composer.suggested.json to /Users/mike.madison/git/Drupal-GovCon-2017/blt/composer.suggested.json
> PhantomInstaller\Installer::installPhantomJS
   - PhantomJS v2.1.1 is already installed. Skipping the installation.
macbookpro-mikemadison:Drupal-GovCon-2017 mike.madison$ composer show dmore/behat-chrome-extension

                                                  
  [InvalidArgumentException]                      
  Package dmore/behat-chrome-extension not found  
                                                  

show [--all] [-i|--installed] [-p|--platform] [-a|--available] [-s|--self] [-N|--name-only] [-P|--path] [-t|--tree] [-l|--latest] [-o|--outdated] [-m|--minor-only] [-D|--direct] [--strict] [-f|--format FORMAT] [--] [<package>] [<version>]

macbookpro-mikemadison:Drupal-GovCon-2017 mike.madison$ composer validate
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.
require.acquia/blt : exact version constraints (9.x-dev) should be avoided if the package follows semantic versioning
require.drupal/memcache : exact version constraints (2.x-dev) should be avoided if the package follows semantic versioning
require.drupal/google_analytics : unbound version constraints (*@stable) should be avoided
require.drupal/components : unbound version constraints (*@stable) should be avoided
require.drupal/acquia_purge : exact version constraints (1.0-beta3) should be avoided if the package follows semantic versioning
require.drupal/twig_xdebug : exact version constraints (1.x-dev) should be avoided if the package follows semantic versioning
require.drupal-composer/drupal-security-advisories : exact version constraints (8.x-dev) should be avoided if the package follows semantic versioning
require.roave/security-advisories : unbound version constraints (dev-master) should be avoided
require.drupal/webform_views : exact version constraints (5.x-dev) should be avoided if the package follows semantic versioning
require.drupal/field_group : exact version constraints (1.0) should be avoided if the package follows semantic versioning
require.drupal/field_permissions : exact version constraints (1.x-dev) should be avoided if the package follows semantic versioning
require.drupal/flag : exact version constraints (4.0.0-alpha2) should be avoided if the package follows semantic versioning
require.acquia/lightning : exact version constraints (3.1.0) should be avoided if the package follows semantic versioning
require.drupal/config_update : exact version constraints (1.5.0) should be avoided if the package follows semantic versioning

@mikemadison13
Copy link
Contributor Author

Comparing with canary, my composer.json is missing the following key:

"require": [
  "blt/composer.required.json",
  "blt/composer.suggested.json"
],

@mikemadison13
Copy link
Contributor Author

manually including the above and then re-running composer update results in:

composer update
Gathering patches for root package.
Removing package drupal/core so that it can be re-installed and re-patched.
  - Removing drupal/core (8.5.1)
Deleting docroot/core - deleted
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 21 installs, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing psr/simple-cache (1.0.1): Loading from cache
  - Installing psr/cache (1.0.1): Loading from cache
  - Installing symfony/polyfill-apcu (v1.7.0): Loading from cache
  - Installing symfony/cache (v3.4.8): Loading from cache
  - Installing symfony/expression-language (v3.4.8): Loading from cache
  - Installing symfony/stopwatch (v3.4.8): Loading from cache
  - Installing sensiolabs-de/deprecation-detector (dev-master d5582d1): Cloning d5582d1661 from cache
  - Installing drupal/core (8.5.1): Loading from cache
  - Applying patches for drupal/core
    https://www.drupal.org/files/issues/2752961-130.patch (Clear Twig caches on deploys)
    https://www.drupal.org/files/issues/ignore_front_end_vendor-2329453-116.patch (Ignore front end vendor folders to improve directory search performance)
    https://www.drupal.org/files/issues/1356278-408--8.5.x-real.patch (1356276 - Allow profiles to provide a base/parent profile and load them in the correct order)
    https://www.drupal.org/files/issues/2880374-remove-experimental-warnings-6.patch (2880374 - Experimental modules should not have warnings after being installed)
    https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch (2869592 - Disabled update module shouldn't produce a status report warning)
    https://www.drupal.org/files/issues/2885441-2.patch (2885441 - EntityReferenceAutocompleteWidget should define its size setting as an integer)
    https://www.drupal.org/files/issues/2815221-87.patch (2815221 - Add quickedit to the latest-revision route)
    https://www.drupal.org/files/issues/2877383-56.patch (2877383 - Add action support to Media module)
    https://www.drupal.org/files/issues/2670730-81-89-8.5.0-rc1.patch (2670730 - Provide a delete action for each content entity type)

  - Installing drupal/config_filter (1.2.0): Loading from cache
  - Installing drupal/config_split (1.3.0): Loading from cache
  - Installing drupal/qa_accounts (1.0.0-alpha1): Loading from cache
  - Installing drupal/seckit (1.0.0-alpha2): Loading from cache
  - Installing drupal/security_review (dev-1.x 9a3bdf8): Cloning 9a3bdf82a6 from cache
  - Installing drupal/features (3.7.0): Loading from cache
  - Installing bex/behat-extension-driver-locator (1.0.2): Loading from cache
  - Installing bex/behat-screenshot (1.2.7): Loading from cache
  - Installing se/selenium-server-standalone (v2.53.1): Loading from cache
  - Installing textalk/websocket (1.2.0): Loading from cache
  - Installing dmore/chrome-mink-driver (2.6.2): Loading from cache
  - Installing dmore/behat-chrome-extension (1.1.0): Loading from cache
  - Installing mikey179/vfsstream (v1.6.5): Loading from cache
bex/behat-screenshot suggests installing bex/behat-screenshot-image-driver-uploadpie (Allows to upload the screenshot to uploadpie.com)
bex/behat-screenshot suggests installing bex/behat-screenshot-image-driver-img42 (Allows to upload the screenshot to img42.com)
bex/behat-screenshot suggests installing bex/behat-screenshot-image-driver-unsee (Allows to upload the screenshot to unsee.cc)
Writing lock file
Generating autoload files
You are using Drupal packages that are not supported by the Drupal Security Team!
  - drupal/qa_accounts:1.0.0.0-alpha1: Project has not opted into security advisory coverage!
  - drupal/seckit:1.0.0.0-alpha2: Alpha releases are not covered by Drupal security advisories.
  - drupal/security_review:dev-1.x: Dev releases are not covered by Drupal security advisories.
See https://www.drupal.org/security-advisory-policy for more information.
> PhantomInstaller\Installer::installPhantomJS
   - PhantomJS v2.1.1 is already installed. Skipping the installation.

mikemadison13 added a commit to mikemadison13/blt that referenced this issue Apr 18, 2018
@mikemadison13
Fixes acquia#2742 to include a composer munge as part of the 9.1 upda…
ae25058 
…te process.
@mikemadison13 mikemadison13 mentioned this issue Apr 18, 2018
Merged
grasmash pushed a commit that referenced this issue Apr 18, 2018
@mikemadison13 @grasmash
Fixes #2742 to include a composer munge as part of the 9.1 update pro…
bc97176 
…cess. (#2745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemadison13 mikemadison13

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grasmash @mikemadison13