Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force certain directories when deploying to Acquia Cloud #227

Closed
webkenny opened this issue Jul 18, 2016 · 3 comments
Closed

Force certain directories when deploying to Acquia Cloud #227

webkenny opened this issue Jul 18, 2016 · 3 comments

Comments

@webkenny
Copy link
Contributor

Problem

Some developers will have a global Git ignore file that will exclude directories such as /vendor or other required directories to be pushed to ACE in develop-build. This causes dependency issues.

Solution

Pull Request incoming but we want to, at minimum, force /vendor to be committed.
webkenny added a commit to webkenny/blt that referenced this issue Jul 18, 2016
@webkenny
acquia#227 Force certain directories when deploying to Acquia Cloud. …
f72a608 
…Add vendor dir and force directive
@webkenny
Copy link
Contributor Author

See #228

@CashWilliams
Copy link
Contributor

I ran into this with something other then /vendor as well.

My global git ignore had something relating to icon files in it, and so some images named 'icon' from http://cgit.drupalcode.org/drupal/tree/core/themes/seven/images?h=8.1.x were not getting added to the deploy commit.

webkenny added a commit to webkenny/blt that referenced this issue Jul 18, 2016
@webkenny
acquia#227 Adding some blob wildcards to the vendor dir so we capture…
40e42d6 
… all files and all vendors.
webkenny added a commit to webkenny/blt that referenced this issue Jul 18, 2016
@webkenny
acquia#227 Fix up the wildcard issue so we don't introduce crazy secu…
8c90eaa 
…rity issues
grasmash pushed a commit that referenced this issue Jul 18, 2016
@webkenny @grasmash
#227 Force certain directories when deploying to Acquia Cloud. (#228)
0a544d7 
* #227 Force certain directories when deploying to Acquia Cloud. Add vendor dir and force directive

* #227 Adding some blob wildcards to the vendor dir so we capture all files and all vendors.

* #227 Fix up the wildcard issue so we don't introduce crazy security issues
@grasmash
Copy link
Contributor

Merged.

@webkenny webkenny mentioned this issue Aug 1, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grasmash @CashWilliams @webkenny