Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Filesets.php overridden by update #1621

Closed
simesy opened this issue Jun 7, 2017 · 2 comments
Closed

Custom Filesets.php overridden by update #1621

simesy opened this issue Jun 7, 2017 · 2 comments
Assignees
@grasmash
Labels
Bug Something isn't working

Comments

@simesy
Copy link

simesy commented Jun 7, 2017

As a developer I want to override BLT outside of vendor directory.

When I updated to HEAD on 8.x this morning, BLT clobbered my ./blt/src/Filesets.php and I had to revert it. I'm guessing this is not ideal, as I assumed that with a namespace like \Acquia\Blt\Custom we should be able to override this.
@simesy
Copy link
Author

simesy commented Jun 7, 2017

It also re-wrote my custom docroot/sites/default/default.settings.php to the BLT default.

@grasmash grasmash added the Bug Something isn't working label Jun 8, 2017
grasmash added a commit to grasmash/bolt that referenced this issue Jun 8, 2017
@grasmash
Fixed acquia#1621: Custom Filesets.php overridden by update.
1f6037c
@grasmash grasmash self-assigned this Jun 8, 2017
@simesy
Copy link
Author

simesy commented Jun 15, 2017

Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grasmash grasmash

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simesy @grasmash