Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence git output when it may output fatal errors #1286

Closed
scor opened this issue Apr 3, 2017 · 1 comment
Closed

Silence git output when it may output fatal errors #1286

scor opened this issue Apr 3, 2017 · 1 comment
Assignees
Labels
Enhancement A feature or feature request

Comments

@scor
Copy link

scor commented Apr 3, 2017

My system information:

  • Operating system type: Mac OS X
  • Operating system version: 10.10.5
  • BLT version: 8.6.15

When I run this command:

blt deploy

I get the following output:

blt > deploy:remote:pull:
fatal: Couldn't find remote ref deploy-build-1
Switched to a new branch 'deploy-build-1'
merge: 281ce531ae6fed2b8dbbca60d0ee5237/deploy-build-1 - not something we can merge
fatal: The remote end hung up unexpectedly

The build works, and I suspect the output above is just a side effect of blt trying different commands to see if the branch already exist, but regardless, the 2 fatal errors in the output above can be misleading, especially in situation where the build fails, which happened to me earlier. If one is familiar with blt and knows that this is something to expect, then fine, but IMO this is not very user friendly, and would deserve to be not displayed if it's not meaningful to the end user. just my 2 cts.

@grasmash grasmash added the Enhancement A feature or feature request label Apr 3, 2017
@grasmash
Copy link
Contributor

grasmash commented Apr 3, 2017

Agreed this makes sense.

grasmash added a commit that referenced this issue Apr 3, 2017
@grasmash grasmash self-assigned this Apr 3, 2017
grasmash added a commit that referenced this issue Apr 3, 2017
…rs." (#1296)

Revert "Fixes #1286: Silence git output when it may output fatal errors." (#1296)
@grasmash grasmash reopened this Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants