write_all nitpicking #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1: write_all always returned a bogus 0, so it might as well return nothing, also the return value was never used for anything. 2: bytes_written should be ssize_t not int could also mention that i'm not happy with the >0 check being just an assert but i don't address that here
|
@divinity76 Thank you for the pull request but actually this project was something I did a while ago in college and am no longer working on it or maintaining it. I think if you want to use it or contribute to it you would probably be better off finding a fork that is actively maintained. |
|
if it's any help, I've been working on a similar project: https://github.com/nixomose/zosbd2 I used buse originally but nbd caused me all sorts of grief so I wrote something a bit more built-to-purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: write_all always returned a bogus 0, so it might as well return nothing, also the return value was never used for anything.
2: bytes_written should be ssize_t not int
could also mention that i'm not happy with the >0 check being just an assert but i don't address that here