-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bunny DNS API verification method #4292
Conversation
Welcome |
All tests passed with HTTPS verification disabled per #4287. I had to re-run the DragonflyBSD test, but it succeeded the second time around. I would note that there was no debug output on DragonflyBSD to find what actually failed, as the --debug param appeared to be missing from the acme.sh call: |
Ugh, just realized the shebang got set to bash. Fixed now! |
`i` should start with `1`. In dns alias mode, the fulldomain doesn't have a `_acme-challenge` prefix.
Thanks for catching the i=1/2 bit, I wasn't familiar with DNS alias mode, and copied the code from dns_dgon.sh since we use Digital Ocean DNS ourselves, and the API seemed closer to Bunny than CF. Regardless, I should have paid more attention to point 3 from the dev guide! Not sure if it matters currently, but I don't think dns_dgon.sh would pass the test suite since the script doesn't reset the value of 'found' in _get_base_domain() and it seems the acmetestXyzRandomName.* tests are run in the same shell session unlike the standard add/rm calls. At any rate, I'll get 9 & 10 done right away, thanks for the reminder! |
Well, I added a section to the wiki, and now it won't render! Just to see if it was my fault, I removed the section and checked the preview, but it still fails. I checked the diff to make sure I didn't add anything unexpected, but I don't know how to "fix" it now. |
It seems the wiki page is too large to render, let me fix it. |
I would appreciate it if you can fix the code. since I don't have an account to test. |
Will give it a shot and see how it goes! |
Adds support for Bunny DNS-01 ACME challenge API included in acme.sh. https://bunny.net/dns/ see acmesh-official/acme.sh#4292
Adds DNS verification for domains using Bunny DNS.