Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bunny DNS API verification method #4292

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

nosilver4u
Copy link
Contributor

Adds DNS verification for domains using Bunny DNS.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Welcome
Please make sure you're read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@nosilver4u
Copy link
Contributor Author

All tests passed with HTTPS verification disabled per #4287. I had to re-run the DragonflyBSD test, but it succeeded the second time around. I would note that there was no debug output on DragonflyBSD to find what actually failed, as the --debug param appeared to be missing from the acme.sh call:
/root/.acme.sh/acme.sh --server "letsencrypt_test" --issue -d "***" -d "*.***" --dns *** --dnssleep "***" [FAIL]

@nosilver4u
Copy link
Contributor Author

nosilver4u commented Sep 6, 2022

Ugh, just realized the shebang got set to bash. Fixed now!

`i` should start with `1`.
In dns alias mode, the fulldomain doesn't have a `_acme-challenge` prefix.
@Neilpang Neilpang merged commit 03288b5 into acmesh-official:dev Sep 7, 2022
@Neilpang
Copy link
Member

Neilpang commented Sep 7, 2022

image

@nosilver4u
Copy link
Contributor Author

Thanks for catching the i=1/2 bit, I wasn't familiar with DNS alias mode, and copied the code from dns_dgon.sh since we use Digital Ocean DNS ourselves, and the API seemed closer to Bunny than CF. Regardless, I should have paid more attention to point 3 from the dev guide!

Not sure if it matters currently, but I don't think dns_dgon.sh would pass the test suite since the script doesn't reset the value of 'found' in _get_base_domain() and it seems the acmetestXyzRandomName.* tests are run in the same shell session unlike the standard add/rm calls.

At any rate, I'll get 9 & 10 done right away, thanks for the reminder!

@nosilver4u
Copy link
Contributor Author

Well, I added a section to the wiki, and now it won't render!
https://github.com/acmesh-official/acme.sh/wiki/dnsapi

Just to see if it was my fault, I removed the section and checked the preview, but it still fails. I checked the diff to make sure I didn't add anything unexpected, but I don't know how to "fix" it now.

@Neilpang
Copy link
Member

Neilpang commented Sep 7, 2022

It seems the wiki page is too large to render, let me fix it.
Thanks

@Neilpang
Copy link
Member

Neilpang commented Sep 7, 2022

Not sure if it matters currently, but I don't think dns_dgon.sh would pass the test suite since the script doesn't reset the value

I would appreciate it if you can fix the code. since I don't have an account to test.

@nosilver4u
Copy link
Contributor Author

Not sure if it matters currently, but I don't think dns_dgon.sh would pass the test suite since the script doesn't reset the value

I would appreciate it if you can fix the code. since I don't have an account to test.

Will give it a shot and see how it goes!

@nosilver4u nosilver4u deleted the bunny branch September 7, 2022 16:47
SpeakinTelnet added a commit to SpeakinTelnet/opnsense-plugins that referenced this pull request Nov 5, 2023
Adds support for Bunny DNS-01 ACME challenge API included in acme.sh.

https://bunny.net/dns/

see acmesh-official/acme.sh#4292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants