New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vultr Api: Update to v2 #4192

Merged

Neilpang merged 1 commit into acmesh-official:dev from skyksandr:master

Jul 19, 2022

Contributor

skyksandr commented Jul 17, 2022

I ran into rate limits when trying to issue single cert for 3 domains.

Vultr Api v1 has rate limit of 2 requests per seconds (source)
Vultr Api v2 - 30 requests per second (source)

In this PR I have updated:

endpoints
Auth header: from Api-Key: ... to Authorization: Bearer ...
Content-Type to application/json

I have verified it working using GitHub Actions https://github.com/skyderby/skyderby/runs/7378330990?check_suite_focus=true

skyksandr mentioned this pull request

Report bugs to Vultr dns api #2374

Open

Member

Neilpang commented Jul 18, 2022

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test


          Update to Vultr Api v2

0717f85

- change endpoints
- change Api-Key header to Authorization: Bearer

Contributor Author

skyksandr commented Jul 18, 2022 •

edited

Loading

@Neilpang done that, could you verify it: https://github.com/skyksandr/acme.sh/actions/runs/2688142460

Also shell check suggests to double quote $VULTR_API_KEY to prevent globbing. What is your opinion on it?

api_key_trimmed=$(echo $VULTR_API_KEY | tr -d '"')

Neilpang merged commit de04192 into acmesh-official:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet