Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow old and new API response for OPNsense Plugin #2879

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

blablup
Copy link
Contributor

@blablup blablup commented Apr 21, 2020

CLOSES #2480

@auto-comment
Copy link

auto-comment bot commented Apr 21, 2020

First, never send a PR to master branch, it will never be accepted. Please send to the dev branch instead.
If this is a PR to support new DNS API or new notification API, please read this guide first: https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Dev-Guide
Please check the guide items one by one.
Then add your usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi

@Neilpang Neilpang merged commit dddfe07 into acmesh-official:dev Apr 24, 2020
@blablup
Copy link
Contributor Author

blablup commented Apr 25, 2020

It is an or. so either it is ","allownotifyslave":{"":{[^}]*}}" or it is only the ",". Use a ")?" would also work, I don't use that often, don't know why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants