Skip to content
This repository has been archived by the owner on Apr 7, 2021. It is now read-only.

🐳 ✏ patched docker configs and updated docker docs #45

Merged
merged 2 commits into from
Mar 27, 2020
Merged

🐳 ✏ patched docker configs and updated docker docs #45

merged 2 commits into from
Mar 27, 2020

Conversation

bmiddha
Copy link
Member

@bmiddha bmiddha commented Mar 27, 2020

  • Updated documentation
  • Breaking Change: Docker Compose files renamed. docker-compose.yml is the development config and docker-compose.prod.yml is the production config
  • Updated api, and client dockerfiles
  • Updated docker-compose configs for dev, and prod

@bmiddha bmiddha self-assigned this Mar 27, 2020
jigar288
jigar288 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@jigar288 jigar288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! This makes it much easier to use docker while devloping

@bmiddha bmiddha merged commit 271bfe1 into master Mar 27, 2020
@bmiddha bmiddha deleted the docker-fix branch March 27, 2020 04:47
@anarmawala anarmawala linked an issue Mar 27, 2020 that may be closed by this pull request
Setup production workflow with docker/kubernetes #23
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jigar288 jigar288 jigar288 approved these changes

@clarkchentw clarkchentw Awaiting requested review from clarkchentw

@anarmawala anarmawala Awaiting requested review from anarmawala

@alexchomiak alexchomiak Awaiting requested review from alexchomiak

Assignees

@bmiddha bmiddha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup production workflow with docker/kubernetes
2 participants
@bmiddha @jigar288