This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Spruce up: Upgrade deps, update Victoria gov calendar URL #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-fetch 3.x is ESM only which breaks with our current TS setup. Since native node fetch API is coming in NodeJS 21 I think the best move is to leave node-fetch alone until then.
d5c291d to
1021a72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
node-fetchwhich is currently on 2.x. 3.x is ESM only which messed with our TS config in a way that I couldn't find a non-ugly fix. Since nativefetchis stable in NodeJS 21 I think we just leavenode-fetchalone until we can upgrade to the native one.