Use full checkout for docker image building #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f396946 to
0a976c5
Compare
0a976c5 to
752d1b1
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
We build the docker tag in part from the number of commits on the current branch. This provides a number value that can only increaase over time. A useful automated "release" or "version" number. However, it relies on `git rev-list` which in turn requires _all_ the commits to be available in order to get an accurate count. The default for github actions is a shallow fetch. So here we change it to fetch the whole shebang whem building the Docker image.
752d1b1 to
77feebf
Compare
jadedarko
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build the docker tag in part from the number of commits on the current branch. This provides a number value that can only increaase over time. A useful automated "release" or "version" number. However, it relies on
git rev-listwhich in turn requires all the commits to be available in order to get an accurate count. The default for github actions is a shallow fetch. So here we change it to fetch the whole shebang whem building the Docker image.