-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Sentry error monitoring #71
Conversation
c952aca
to
e0b4dcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - I don't think that we should include a view for triggering errors that anyone can visit at any time.
e0b4dcf
to
cdadba9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added details about what our traditional settings are for Sentry across our apps - otherwise this looks good.
I would also suggest possibly adding this as a commented out line after the config:
sentry_sdk.integrations.logging.ignore_logger("django.security.DisallowedHost")
because
- sometimes our apps have reasons for requests that trigger this error in which case we don't want to be told about it
- i.e. one client runs tennable.io from behind their WAF, and another client manages the infrastructure and has decided to make the app publicly accessible - in both cases, this error is the correct and desired response, so it just creates noise having it reported to Sentry
- it strongly hints at how you can handle these kind of errors in situations where they're overly noisy, as it doesn't seem to be signposted well enough
- for some reason the most common solution I see people PRing is creating a custom
before_send
filter, which as things go isn't the worst thing, but it's still more complex than this 😅
- for some reason the most common solution I see people PRing is creating a custom
cdadba9
to
e2431fb
Compare
0505b44
to
2737ba0
Compare
Enable sending errors/exceptions to Sentry monitoring system. This PR completes a part of #17 which does the following: