Merge appcast into Build CI #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vit9696
reviewed
Sep 19, 2021
|
Could you change:
In other steps? Otherwise the CI will yell at this PR. |
Added. |
vit9696
reviewed
Sep 19, 2021
.github/workflows/main.yml
Outdated
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: Artifacts | ||
| path: build/*/*.dmg | ||
|
|
||
| - name: Upload to Release | ||
| if: github.event_name == 'release' && github.repository_owner == 'acidanthera' | ||
| if: github.event_name == 'release' && github.repository_owner == 'acidanthera' && github.event_name != 'pull_request' |
There was a problem hiding this comment.
This one is always true, no need to check for pull_request here and below where there is a release check already.
|
Seems to be working well, thanks for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.