Guard against sending heartbeats if the underlying socket is closed #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the connection to the server is lost before the library gets a chance to detect this and cancel the heartbeat timer, there is a small window where the client will attempt to send a heartbeat and an exception will be thrown. This commit attempts to guard against this by checking the channel and socket status before attempting to transmit the heartbeat message as well as by wrapping the send request in a try/catch block and suppressing any thrown exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the connection to the server is lost before the library gets a chance to detect this and cancel the heartbeat timer, there is a small window where the client will attempt to send a heartbeat and an exception will be thrown.
This commit attempts to guard against this by checking the channel and socket status before attempting to transmit the heartbeat message as well as by wrapping the send request in a try/catch block and suppressing any thrown exceptions.
Fixes #94