Fix reconnect related bugs #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses one of the issues described in #107. Prior to this change, the error broadcast stream was always closed when the connection was closed either by the client or the server. This prevented clients that implemented a reconnection policy from being able to register error listeners. This commit modifies the client behavior so that the error broadcast channel is only closed if the client invokes the close() method on a client instance.
This commit fixes a bug in the reconnect handling code where the client would overwrite a pre-existing heartbeat timer without first cancelling it. As a result, the old timer would eventually fire and trigger a HeartbeatFailedException closing the connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the reconnection-handling logic that were reported in #107:
The client error broadcast stream is now closed only if the client's
close()method is explicitly called. This allows existing listeners to be re-used if the client opts to detect connection loss events and reconnect to the broker.When reconnecting, the previous heartbeat check timer was overwritten without first being cancelled. As a result, the old timer would eventually fire and raise a HeartbeatFailedException which would in turn trigger a new connection attempt to be made.
fixes #107