Shutdown consumer streams when the underlying channel closes #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that if a channel closes, either because the channel's close() method was invoked or because a channel-closing exception occurred, any pending in-flight operations as well as any active consumers are properly terminated.
af8f684 to
e66a146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that if a channel closes, either because the channel's
close()method was invoked or because a channel-closing exception occurred, any pending in-flight operations as well as any active consumers are properly terminated.Prior to this change, the implementation would just terminate in-flight operations in case of a channel-closing exception but leave the existing consumer streams open.
Fixes #99