Arsenal - Fix FUNC(baseAttachment) returning non-CBA item modes

[johnb432]

When merged this pull request will:

• Title.
• This assumes that each attachment that has valid entries redefines them.
• Needs more testing. I tested with RHS, but I want more testing from others.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[LinkIsGrim]

https://github.com/CBATeam/CBA_A3/blob/master/addons/accessory/fnc_switchAttachment.sqf#L48-L53 CBA ignores inherited values, so can we

[LinkIsGrim]

Fix the thing

[johnb432]

https://github.com/CBATeam/CBA_A3/blob/master/addons/accessory/fnc_switchAttachment.sqf#L48-L53 CBA ignores inherited values, so can we

Do we want to adopt the same code as CBA then?

[LinkIsGrim]

Pretty sure this is good enough, up to you.

[johnb432]

Pretty sure this is good enough, up to you.

My solution is quite a bit faster, but I'm not sure if they do the exact same thing.

[LinkIsGrim]

Result is the same, configProperties with no inheritance will result in empty array which just breaks that loop, same as exiting if inheritsFrom is not the property itself (technically it could be the case that some attachments in the chain inherit and others don't while this just checks the first, but CBA doesn't support that, and we end up checking everything in the chain anyway due to how this is called)