New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Cleanup action UI code #9784

Merged

LinkIsGrim merged 2 commits into master from arsenal-actions-code-cleanup

Feb 11, 2024

Contributor

LinkIsGrim commented Feb 9, 2024 •

edited

Loading

When merged this pull request will:

Move some things around to reduce duplicate code
Remove an unused variable
Fix hidden controls potentially going outside of actions control group area
Remove action focus setting. Root cause for lockups was found to be above

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

LinkIsGrim added 2 commits

February 8, 2024 22:10


          Arsenal - Cleanup action UI code

100dd90


          derp

10b9c50

LinkIsGrim added the kind/cleanup label

LinkIsGrim added this to the 3.16.4 milestone

johnb432 approved these changes

View reviewed changes

LinkIsGrim merged commit 95ec6eb into master

5 checks passed

LinkIsGrim deleted the arsenal-actions-code-cleanup branch

February 11, 2024 22:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels