Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Fix animations not playing properly #9705

Merged
merged 10 commits into from
Jan 1, 2024
Merged

Arsenal - Fix animations not playing properly #9705

merged 10 commits into from
Jan 1, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jan 1, 2024 •
edited by LinkIsGrim
Loading

When merged this pull request will:

  • Add common FUNC(stopGesture). Credit: ACRE mod
  • Prevent losing magazines by opening the arsenal while reloading.
  • Fix floating weapons/misaligned grips while browsing.
  • Make arsenal open left panel for the currently selected weapon.
  • Fix missing removeVest command in VR Arsenal.
  • Fix weapon animations misbehaving when opening the arsenal in the middle of a weapon switch.
  • Repro steps: Switch weapons and open the arsenal. You can observe the animations misbehaving.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 requested a review from LinkIsGrim January 1, 2024 01:41
@LinkIsGrim
Copy link
Contributor

Review when I'm sober.

@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Jan 1, 2024
@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Jan 1, 2024
LinkIsGrim
LinkIsGrim previously requested changes Jan 1, 2024
View reviewed changes
johnb432 and others added 2 commits January 1, 2024 02:09
@johnb432 @LinkIsGrim
Update addons/arsenal/functions/fnc_showItem.sqf
136eee7 
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@johnb432
Moved to common
602e0b5
@johnb432 johnb432 requested a review from LinkIsGrim January 1, 2024 10:41
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Jan 1, 2024 •
edited
Loading

I wasn't intending on hijacking this but I got carried away. Someone else review

veteran29
veteran29 approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

johnb432
johnb432 commented Jan 1, 2024
View reviewed changes
Copy link
Contributor Author

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnb432 johnb432 merged commit 0f08ba2 into master Jan 1, 2024
@johnb432 johnb432 deleted the arsenal-animation branch January 1, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

@LinkIsGrim LinkIsGrim Awaiting requested review from LinkIsGrim

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @LinkIsGrim @veteran29