-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common - Make FUNC(isModLoaded)
case-insensitive
#9704
Conversation
I think we should make the func non-case sensitive and easy to use (it's are non-ansi even allowed in config names? |
I'm not sure why it wasn't made case-insensitive when the cache was introduced (performance concerns on using a toLower)? The function works regardless, a cache miss due to casing just means the config lookup is done again. But yeah it should be changed IMO AFAIK non-ANSI isn't allowed in config, no. |
Mod name (I assume this was to be used with modParams) never actually worked, updated header to match. |
FUNC(isModLoaded)
case-insensitive
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
When merged this pull request will:
ace_common_fnc_isModLoaded
is not case sensitive, but that means adding atoLowerANSI
.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.