Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Use canAdd to check if item can be added to container #9699

Merged
merged 5 commits into from
Dec 31, 2023
Merged

Arsenal - Use canAdd to check if item can be added to container #9699

merged 5 commits into from
Dec 31, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Dec 31, 2023 •
edited
Loading

When merged this pull request will:

  • Title. Makes items also respect config allowedSlots[] property now.
  • Drop mass property from right panel cache and ListNBox. I'm 99% 3rd parties don't use this anyway.
  • Drop itemInfo param and lookups from right panel cache. Not needed due to dropping mass.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Dec 31, 2023
johnb432
johnb432 approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinkIsGrim LinkIsGrim merged commit 106c094 into master Dec 31, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Dec 31, 2023
@jonpas jonpas deleted the arsenal-canAdd-container branch December 31, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@LinkIsGrim @johnb432