Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markers - Use lbData for channel selection #9693

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Markers - Use lbData for channel selection #9693

merged 2 commits into from
Dec 31, 2023

Conversation

Avokadomos
Copy link
Contributor

@Avokadomos Avokadomos commented Dec 30, 2023 •
edited
Loading

When merged this pull request will:
Make channel changes in the marker placement window based on the lbData of the selection, instead of its index in the list. This way, the order of the items won't matter, and mods that manipulate the list (e.g. deletes items) won't break its functionality.

Avokadomos referenced this pull request Dec 30, 2023
@LinkIsGrim
Markers - Fix issues with custom channels (#9383)
f7b520b
@LinkIsGrim
Copy link
Contributor

is lbData automatically set and correct?

LinkIsGrim
LinkIsGrim approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref my comment: yes, it is.

@LinkIsGrim LinkIsGrim changed the title Markers - Improve channel selection so that it's based on lbData instead of index Markers - Use lbData for channel selection Dec 31, 2023
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Dec 31, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Dec 31, 2023
@LinkIsGrim LinkIsGrim merged commit c3f442f into acemod:master Dec 31, 2023
5 checks passed
@Avokadomos
Copy link
Contributor Author

It actually doesn't make sense to fetch channels from ace_markers_fnc_getEnabledChannels. If there's a custom channel for example, the select will go out of bounds.

Can we just use lbData without fetching anything from ace_markers_fnc_getEnabledChannels? The channels in the listbox will always correspond to what's in _enabledChannels anyway right?

This was referenced Dec 31, 2023
Merged
Closed
@Avokadomos Avokadomos deleted the patch-1 branch December 31, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Avokadomos @LinkIsGrim