Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging - Fix captives #9660

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Dragging - Fix captives #9660

merged 1 commit into from
Nov 21, 2023

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • FUNC(handleKilled) must be called locally, which I completely forgot to take into account when improving the dragging component.
  • Some minor code cleanup.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Nov 21, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Nov 21, 2023
@LinkIsGrim LinkIsGrim merged commit 2e7f56e into master Nov 21, 2023
5 checks passed
@jonpas jonpas deleted the dragging-fixes branch November 21, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @PabstMirror @LinkIsGrim