Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo - Add item index and damage to cargo menu #9655

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Nov 17, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Nov 17, 2023
@LinkIsGrim LinkIsGrim requested a review from johnb432 November 17, 2023 23:31
@johnb432
Copy link
Contributor

johnb432 commented Nov 19, 2023

Do we want to display health or damage?
Imo health is more intuitive.

Also, I didn't think of this, but why do we display unload times for airdropped items only? Why not add it to all?
In the past I imagine it was because the input was blocked and it allows pilots to better gauge when they need to start dropping, but now the former is no longer an issue.

@rautamiekka
Copy link
Contributor

Do we want to display health or damage? Imo health is more intuitive.

Agree.

@LinkIsGrim
Copy link
Contributor Author

LinkIsGrim commented Nov 19, 2023

Health doesn't have good translations, and not really applicable since we're talking about inanimate objects.

Misclicked close.

@LinkIsGrim LinkIsGrim closed this Nov 19, 2023
@LinkIsGrim LinkIsGrim reopened this Nov 19, 2023
@rautamiekka
Copy link
Contributor

Health doesn't have good translations

Just use (30%).

, and not really applicable since we're talking about inanimate objects.

That's just the other side of the coin, 30% damage being 70% health left, and like we both said, unintuitive.

Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the semicolons and I'm happy.

addons/cargo/functions/fnc_onMenuOpen.sqf Outdated Show resolved Hide resolved
addons/cargo/functions/fnc_onMenuOpen.sqf Outdated Show resolved Hide resolved
LinkIsGrim and others added 2 commits November 20, 2023 22:42
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@LinkIsGrim LinkIsGrim enabled auto-merge (squash) November 21, 2023 01:42
@LinkIsGrim LinkIsGrim merged commit 3904240 into acemod:master Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants