Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Fix closing arsenal when ignoring content #9651

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 requested a review from LinkIsGrim November 15, 2023 21:35
@johnb432
Copy link
Contributor Author

Not sure if

if (!isNil QGVAR(currentBox) && {GVAR(currentBox) isEqualTo _object}) then {

should also be updated to include that check - thoughts?

@LinkIsGrim
Copy link
Contributor

Not sure if

if (!isNil QGVAR(currentBox) && {GVAR(currentBox) isEqualTo _object}) then {

should also be updated to include that check - thoughts?

Yes

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Nov 15, 2023
@LinkIsGrim LinkIsGrim merged commit 65c16b6 into master Nov 16, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Nov 16, 2023
@jonpas jonpas deleted the open-box-fix branch November 17, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants