Medical GUI - Show warning if tourniquet will interfere with medical menu action #9475

amsteadrayle · 2023-10-10T20:21:16Z

When merged this pull request will:

Show a warning tooltip if a tourniquet will interfere with a medical menu action

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

amsteadrayle · 2023-10-10T20:23:58Z

tourniquetwarning.mp4

To be clear, this does not prevent or obstruct medical actions. It only adds a tooltip to make the player aware of the situation.

This overlaps with #9474, and the intent is that this tooltip will override the item count tooltip.

johnb432 · 2023-10-11T06:22:38Z

addons/medical_gui/functions/fnc_updateActions.sqf

@@ -50,6 +50,16 @@ private _shownIndex = 0;
        _ctrl ctrlSetPositionY POS_H(1.1 * _shownIndex);
        _ctrl ctrlCommit 0;

+        // Show warning if tourniquet will interfere with action
+        if (((_category in ["examine", "medication"]) || (_items findIf {"IV" in _x}) > -1)


Isn't there an IV category? The _items findIf {"IV" in _x}) > -1 check is too specific imo.

IVs are in the advanced category, shared with things like stitching and CPR. Checking the item name was the most succinct way I could figure out without having to pass extra information about the actions.

Item config properties can be checked instead to determine if it's an IV, but oof...

I don't like the idea of relying on classnames.

amsteadrayle · 2023-10-11T07:09:14Z

I've elected to not add a setting for this. To me, the warning is universal and low-impact enough to just have it always on. If you all disagree, then I'm fine with adding a setting. I just didn't want to go ahead and add yet another setting if it wasn't needed.

(By universal I mean that it's applicable regardless of what settings someone might use, as far as I'm aware.)

LinkIsGrim · 2023-10-11T09:34:51Z

I'm not sure on this one. It is definitely a UX improvement for casual players, but it feels like giving up one of the finer details that makes the medical system unique (even if it's still there, some of the magic is gone with this being shown).

I think this isn't necessary with the addition of the outline, honestly.

amsteadrayle · 2023-10-12T02:30:53Z

That does makes sense for the people who are interested in engaging with a detailed medical system - making them pay closer attention. But this warning would be a good way to teach new and casual players about one of the more subtle and otherwise invisible mistakes that can be made. Especially since that mistake can directly lead to player death and a generally negative experience.

I'd like it as a setting that's on by default and not global.

jonpas · 2023-10-12T02:39:52Z

If you want to teach a new player something, it could be a one-time thing. But I don't think we have anything else like that in ACE3.

amsteadrayle · 2023-10-13T05:35:13Z

I shouldn't have worded it as teaching. Thinking on it more, it's about having a user interface where, if a button is not going to do what it normally does, the user should be told that.

Drofseh · 2023-10-13T07:22:00Z

Do this and the tooltip for # of items interfere/overlap or anything?

jonpas · 2023-10-13T10:34:05Z

I shouldn't have worded it as teaching. Thinking on it more, it's about having a user interface where, if a button is not going to do what it normally does, the user should be told that.

I understand, but in this case, the user can do it, as you can do it in real life. That button will do just fine what it says it will do. The resulting effects are a different story and have nothing to do with this UX in particular.

amsteadrayle · 2023-10-13T17:56:20Z

Do this and the tooltip for # of items interfere/overlap or anything?

This warning will override the tooltip for # of items.

amsteadrayle · 2023-10-13T17:58:18Z

This should be all set to merge now, whether or not you decide to add it.

addons/medical_gui/stringtable.xml

addons/medical_gui/functions/fnc_updateActions.sqf

LinkIsGrim · 2023-10-13T23:51:36Z

addons/medical_gui/initSettings.sqf

+    [LSTRING(TourniquetWarning_DisplayName), LSTRING(TourniquetWarning_Description)],
+    [ELSTRING(medical,Category), LSTRING(SubCategory)],
+    false,
+    false


Suggested change

false

true

Global

Oh really? It seems like something that would be left to the player unless admins specifically care. That's my assumption for UI stuff in general.

Oh really? It seems like something that would be left to the player unless admins specifically care. That's my assumption for UI stuff in general.

I agree with this. @LinkIsGrim Why would you want to enforce it globally?

Given the effect, I'd rather this be really deliberate on when it's enabled.

That being said, vox populi and all that.

I don't think this needs to be global. Community admins can force if they want to.

addons/medical_gui/functions/fnc_updateActions.sqf

LinkIsGrim · 2023-10-13T23:56:31Z

addons/medical_gui/functions/fnc_updateActions.sqf

        _ctrl ctrlSetTooltip _countText;

+        // Show warning if tourniquet will interfere with action
+        if (GVAR(tourniquetWarning)
+        && {(_category in ["examine", "medication"]) || (_items findIf {"IV" in _x}) > -1}


Suggested change

&& {(_category in ["examine", "medication"]) || (_items findIf {"IV" in _x}) > -1}

&& {(_category in ["examine", "medication"]) || (_items findIf {"IV" in _x}) > -1}

Still don't like the IV check, but anything else requires config lookups/caching items.

I don't really have the means to properly investigate the solution I am proposing, but maybe if

ACE3/addons/medical_gui/functions/fnc_updateActions.sqf

Line 41 in 4647360

_x params ["_displayName", "_category", "_condition", "_statement", "_items"];

gives the statement defined e.g. here

ACE3/addons/medical_treatment/ACE_Medical_Treatment_Actions.hpp

Line 157 in f774eaf

callbackSuccess = QFUNC(ivBag);

we could use that instead?

It's still specific, but the medical system wasn't designed with this in mind (and I don't see a good way to implement it). It's fine. I think most 3rd party IVs will have "IV" in their classname.

If anything, enforcing the " IV" (notice the leading space) name requirement would be 1 way to ensure support with ACE outside config, assuming the 3rd-party dev gives a fuck.

Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>

LinkIsGrim · 2023-10-14T23:28:18Z

we ball²

Warn if tourniquet will interfere with medical action

d2c4bdb

johnb432 reviewed Oct 11, 2023

View reviewed changes

Add setting to enable, default to off

64a3026

Merge branch 'master' into tourniquetWarning

e7e5f41

Drofseh reviewed Oct 13, 2023

View reviewed changes

addons/medical_gui/stringtable.xml Outdated Show resolved Hide resolved

Tweak tooltip message

8d602dd

LinkIsGrim requested changes Oct 13, 2023

View reviewed changes

amsteadrayle and others added 2 commits October 14, 2023 00:13

Tweak code style, missing semicolon

86ff46b

Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>

Use localize macro

4647360

Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>

LinkIsGrim approved these changes Oct 14, 2023

View reviewed changes

LinkIsGrim added this to the 3.16.0 milestone Oct 14, 2023

LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Oct 14, 2023

LinkIsGrim merged commit c54a26c into acemod:master Oct 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Medical GUI - Show warning if tourniquet will interfere with medical menu action #9475

Medical GUI - Show warning if tourniquet will interfere with medical menu action #9475

amsteadrayle commented Oct 10, 2023

amsteadrayle commented Oct 10, 2023

johnb432 Oct 11, 2023

amsteadrayle Oct 11, 2023

LinkIsGrim Oct 11, 2023

amsteadrayle commented Oct 11, 2023

LinkIsGrim commented Oct 11, 2023

amsteadrayle commented Oct 12, 2023

jonpas commented Oct 12, 2023

amsteadrayle commented Oct 13, 2023

Drofseh commented Oct 13, 2023

jonpas commented Oct 13, 2023

amsteadrayle commented Oct 13, 2023

amsteadrayle commented Oct 13, 2023

LinkIsGrim Oct 13, 2023

amsteadrayle Oct 14, 2023

johnb432 Oct 14, 2023

LinkIsGrim Oct 14, 2023

Drofseh Oct 14, 2023 •

edited

Loading

LinkIsGrim Oct 13, 2023

johnb432 Oct 14, 2023

LinkIsGrim Oct 14, 2023

rautamiekka Oct 14, 2023

LinkIsGrim commented Oct 14, 2023

	&& {(_category in ["examine", "medication"]) \|\| (_items findIf {"IV" in _x}) > -1}
	&& {(_category in ["examine", "medication"]) \|\| (_items findIf {"IV" in _x}) > -1}

Medical GUI - Show warning if tourniquet will interfere with medical menu action #9475

Medical GUI - Show warning if tourniquet will interfere with medical menu action #9475

Conversation

amsteadrayle commented Oct 10, 2023

IMPORTANT

amsteadrayle commented Oct 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amsteadrayle commented Oct 11, 2023

LinkIsGrim commented Oct 11, 2023

amsteadrayle commented Oct 12, 2023

jonpas commented Oct 12, 2023

amsteadrayle commented Oct 13, 2023

Drofseh commented Oct 13, 2023

jonpas commented Oct 13, 2023

amsteadrayle commented Oct 13, 2023

amsteadrayle commented Oct 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Drofseh Oct 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LinkIsGrim commented Oct 14, 2023

Drofseh Oct 14, 2023 •

edited

Loading