Reload - Add manual reload for vehicle weapons - continued

[johnb432]

When merged this pull request will:

• Title. Continuation of Add manual reload for vehicle weapons #5827, credit to @PabstMirror.
• FUNC(canSwapTurretMagazine) has been altered slightly from its original form, but the functionality is the same.
• FUNC(swapTurretMagazine) has been significantly changed. Previously it removed all turret magazines, whereas now it uses the "LoadMagazine" action to change magazines.
• Added an icon to the action (icon is from base game).

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[johnb432]

Instead of this being an ACE interaction, it could be made to trigger when pressing the reload key instead. Thoughts?

[Drofseh]

Instead of this being an ACE interaction, it could be made to trigger when pressing the reload key instead. Thoughts?

Both? Both!

[johnb432]

Both? Both!

Fair enough xD

On another note: Should there be a CBA setting enabling/disabling this feature or parts of it?

[Drofseh]

I don't really think it needs a setting

[PabstMirror]

    class HMG_01;
    class HMG_static: HMG_01 {
        type = 1;
    };

will let the engine reload via R key

[johnb432]

    class HMG_01;
    class HMG_static: HMG_01 {
        type = 1;
    };

will let the engine reload via R key

Should that be integrated into this PR? As in use that for static weapons, weapons on vehicles or vehicles (I'm unsure if it applies to CfgVehicles or CfgWeapons)?
Or it could check if type = 1 is set for the weapon/vehicle in the addUserActionEventHandler?

What do you suggest doing with that config entry?

[PabstMirror]

We could just add type = 1; too all static weapons to make them reloadable via engine
I can't see any downside to this except that it's more config work

[johnb432]

    class HMG_01;
    class HMG_static: HMG_01 {
        type = 1;
    };

will let the engine reload via R key

Are you sure about this? I have just tried loading CBA and ACE and using any static weapon (all vanilla static weapons have type = 1). I couldn't get any of weapons to reload their magazines. It's true, I couldn't get it to work because I was changing the vehicle's type, not the weapon's.

[ampersand38]

Would repacking magazines / relinking belts be in scope here?

[johnb432]

Would repacking magazines / relinking belts be in scope here?

I think it would be best as a independent ACE interaction, instead of happening automatically when reloading (if I understood your code correctly).
But I would absolutely love it to be a part of ACE. Best to make another PR imo.

[PabstMirror]

we've really put it off but #9085
contains a lot of what we want for repacking/relinking

[Drofseh]

I don't know if 9085 covers it or not, but any packing/linking for vehicles will need to keep the empty magazines or ace rearm can fail with scripted loadouts.

[johnb432]

I don't know if 9085 covers it or not, but any packing/linking for vehicles will need to keep the empty magazines or ace rearm can fail with scripted loadouts.

I was thinking if I would need to adjust this PR for that, but it doesn't look like it. The reload action only happens if there is some ammo available in the weapon (but not a full magazine).

[johnb432]

We can make it so that this is disabled when CSW is enabled for vehicles, when we get around to merging 9085.