Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging - Improve featureCamera handling #9389

Merged
merged 8 commits into from
Sep 20, 2023

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Upon entering an arsenal, the player will drop his dragged or carried object.
  • Applies to both BI and ACE arsenals.
  • Only applies if the player opens the arsenal on himself.

The right click pop-up is annoying and distracting if you enter an arsenal.

That's why I'm thinking of something similar for when entering the Zeus interface, especially if you use ZEN which uses right clicks. Thoughts on that idea?

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Sep 11, 2023

featureCamera CBA event is more generic, if you'd like to use that.

@johnb432
Copy link
Contributor Author

featureCamera CBA event is more generic, if you'd like to use that.

Updated to include that change. Are there any cameras that should allow dragging/carrying?

@jonpas
Copy link
Member

jonpas commented Sep 12, 2023

Splendid Camera should probably allow it.

@LinkIsGrim
Copy link
Contributor

featureCamera CBA event is more generic, if you'd like to use that.

Updated to include that change. Are there any cameras that should allow dragging/carrying?

Player probably shouldn't drop items when opening Zeus, either.

@rautamiekka
Copy link
Contributor

featureCamera CBA event is more generic, if you'd like to use that.

Updated to include that change. Are there any cameras that should allow dragging/carrying?

Player probably shouldn't drop items when opening Zeus, either.

Yeah, definitely not, will cause more problems than solves/prevents.

@johnb432
Copy link
Contributor Author

Player probably shouldn't drop items when opening Zeus, either.

Any particular reason why?

Currently if you are dragging/carrying and go into Zeus, the mouse button hint is in the middle of the screen - not a huge deal, but unnecessary and annoying imo.
If you want to move your camera, you will drop the dragged/carried object anyway. I don't understand why you would want to limit yourself by not right-clicking, just to keep the dragged/carried object. Imo far easier to drop and pick up again afterwards.


An entirely different approach to this problem could be to "pause" dragging/carrying whilst in any camera other than default. By "pause" I mean remove the mouse button hint and remove the mouse button EH. When getting back into the default camera, those would be added back.

I'm heavily leaning towards this new approach, would be more elegant imo.

@rautamiekka
Copy link
Contributor

Dropping could have 2 effects:

  1. Tip off the observing players to be unnecessarily cautious, cuz at minimum it looks strange that the Zeus drops something, leaves it there for at least a bit, then picks it up again, and likely rinse-and-repeat, as he's using the interface to see what the Players are doing.
  2. Cause a script depending on the Zeus carrying/dragging to break, malfunction, or fire early.

In other words it would hurt or break the story. I don't see any reasons for this for the Zeus interface.


Yeah, the "pause" is a better way.

@johnb432
Copy link
Contributor Author

Pause has been added.

@LinkIsGrim LinkIsGrim changed the title Arsenal - Improve handling of dragged and carried objects Dragging - Improve handling of dragged and carried objects Sep 20, 2023
@LinkIsGrim LinkIsGrim changed the title Dragging - Improve handling of dragged and carried objects Dragging - Improve featureCamera handling Sep 20, 2023
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Sep 20, 2023
@LinkIsGrim LinkIsGrim merged commit 11664b0 into acemod:master Sep 20, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Sep 20, 2023
@johnb432 johnb432 deleted the stop-dragging-arsenal branch January 14, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants