-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General - Use subcomponent macro (CBA 3.16.0) #9375
Conversation
VERSION_CONFIG; | ||
|
||
addonRootClass = QUOTE(COMPONENT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding this, I am not sure if we want it?
CfgPatches
wiki page says:
To make configuration of meta data simpler, you can simply create a link to the root class instead of defining name, author and url again. A good practice is to have all configs withing one PBO to use the same meta data.
But some of our compats might be better off requiring a subcomponent specifically?
addons/huntir/subConfig/config.cpp
Outdated
@@ -12,6 +11,8 @@ class CfgPatches { | |||
author = ECSTRING(common,ACETeam); | |||
url = ECSTRING(main,URL); | |||
VERSION_CONFIG; | |||
|
|||
addonRootClass = QUOTE(COMPONENT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in game it's addonRootClass = "huntir";
for all of these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addonRootClass = QUOTE(COMPONENT); | |
addonRootClass = QUOTE(ADDON); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Right... whoever did the compats subconfigs did that too, eg.
addonRootClass = QUOTE(COMPONENT); |
Will fix in this PR. But I wonder if we even need/want this, see above comment.
When merged this pull request will:
SUBCOMPONENT
andSUBADDON
with Add subcomponent support to macros CBATeam/CBA_A3#1598SUBCOMPONENT_BEAUTIFIED
script_component.hpp
(fromconfig.cpp
)IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.Requires CBA v3.16.0 - CBATeam/CBA_A3#1598!
Tested with: