Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Add option to show live search results #9354

Merged
merged 8 commits into from
Oct 28, 2023
Merged

Conversation

PabstMirror
Copy link
Contributor

No description provided.

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Aug 30, 2023
@PabstMirror PabstMirror added this to the Ongoing milestone Aug 30, 2023
@LinkIsGrim
Copy link
Contributor

It works well but it would look better if the refresh animation was skipped with live search.

@PabstMirror PabstMirror marked this pull request as ready for review September 4, 2023 04:02
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.16.1 Sep 4, 2023
@PabstMirror PabstMirror modified the milestones: 3.16.1, Ongoing Oct 23, 2023
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.16.2 Oct 26, 2023
@LinkIsGrim
Copy link
Contributor

I'm all for just making this the new default.

@PabstMirror
Copy link
Contributor Author

I'm not sure;
testing with a big modset
typing is fine as it's not doing a full search each time
hitting backspace and it does a full search and it can be a little sluggish
but all the keypresses are "buffered" so it still works fine

maybe we should just get some real-world testing on dev branch and decide later about making it default

@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented Oct 26, 2023

We could modify

private _skip = GVAR(favoritesOnly) && {!(_className in GVAR(currentItems))} && {!((toLower _className) in GVAR(favorites))};
if (_skip) then {
switch (GVAR(currentLeftPanel)) do {
case IDC_buttonPrimaryWeapon: {
_skip = !(_className in (GVAR(currentItems) select IDX_CURR_PRIMARY_WEAPON_ITEMS));
};
case IDC_buttonHandgun: {
_skip = !(_className in (GVAR(currentItems) select IDX_CURR_HANDGUN_WEAPON_ITEMS));
};
case IDC_buttonSecondaryWeapon: {
_skip = !(_className in (GVAR(currentItems) select IDX_CURR_PRIMARY_WEAPON_ITEMS));
};
case IDC_buttonBinoculars: {
_skip = !(_className in (GVAR(currentItems) select IDX_CURR_BINO_ITEMS));
};
};
};
to skip the item if it doesn't match search as well. That would be faster, but maybe a bit dirty?

@LinkIsGrim LinkIsGrim merged commit 3c8cff7 into master Oct 28, 2023
@BrettMayson BrettMayson deleted the asenalLiveResults branch October 28, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants