-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arsenal - Favorites System #9307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
LinkIsGrim
commented
Aug 5, 2023
@@ -19,6 +19,9 @@ | |||
#define ASCENDING 0 | |||
#define DESCENDING 1 | |||
|
|||
// Favorites | |||
#define FAVORITES_COLOR (GVAR(favoritesColor) + [1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since alpha is modified for the right panel (in case the item doesn't fit), I opted for this solution instead, but it's a bit dirty.
johnb432
reviewed
Aug 5, 2023
johnb432
reviewed
Aug 5, 2023
johnb432
reviewed
Aug 5, 2023
That should be all the bugs handled (besides the search bar losing focus if you hover over a button in the menu bar). |
PabstMirror
approved these changes
Aug 20, 2023
LinkIsGrim
commented
Aug 20, 2023
BrettMayson
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
FUNC(refresh)
public, add parameter to skip updating current/unique items.Default mode can be controlled by CBA Setting, so can the highlight color. I'd go for icons instead but we'd have to either overwrite mod icons if an item is favorited or make left panel a listnbox as well (and it would be cluttered on the right panel unless its width was increased).
EDIT: Now that this works, I've tried out using icons. The ones available in vanilla look ugly as sin, and clutter is still a problem, particularly with magazine names.
Favorites can be added/removed by double clicking an item while holding left shift and are saved to profileNamespace.
Still works with sorting/searching.
Current items (including inventory) are also displayed in favorites, without the highlight color.
Favorites are always saved in lowercase to prevent them being affected by configCase changes (mod pack changes or updates).
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.