Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Use weaponDisassemblyEnabled in FUNC(claim) #9304

Closed
wants to merge 3 commits into from

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Aug 2, 2023

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added kind/enhancement Release Notes: **IMPROVED:** 2.14 labels Aug 2, 2023
@LinkIsGrim LinkIsGrim added this to the Ongoing milestone Aug 2, 2023
@@ -30,16 +30,18 @@ _target setVariable [QGVAR(owner), _unit, true];

// lock target object
if (_lockTarget) then {
private _canBeDisassembled = ([] isNotEqualTo getArray (configOf _target >> "assembleInfo" >> "dissasembleTo")) && { !([false, true] select (_target getVariable [QEGVAR(csw,assemblyMode), 0])) };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assemblyMode can go from 0-3 so I think this is/was broken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably?

@PabstMirror PabstMirror modified the milestones: Ongoing, 3.16.1 Sep 3, 2023
@LinkIsGrim
Copy link
Contributor Author

Ref #9413

@LinkIsGrim LinkIsGrim closed this Sep 19, 2023
@LinkIsGrim LinkIsGrim removed this from the 3.16.1 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ace_common_fnc_claim break CSW vanilla disassembly block
2 participants