Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Fatigue - Add cap to muscle damage #9302

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Aug 1, 2023

When merged this pull request will:

  • Previously, muscle damage could go above 1 and cause issues with stamina calculation. Realistically this could probably never happen, as getting muscle damage up to 1 is quite a challenge, but I think it's best to be cautious nonetheless.

TODO: Implement muscle damage recovery, as it could technically pose a problem, although practically I don't know if it does.

I'm hoping to be able to fix advanced fatigue with high performance factor and recovery factor values, but so far I haven't had any luck in reproducing any errors. Any help is appreciated.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Aug 1, 2023
@LinkIsGrim LinkIsGrim changed the title Advanced fatigue - Fix muscle damage not being capped Advanced Fatigue - Add cap to muscle damage Aug 1, 2023
@LinkIsGrim
Copy link
Contributor

cause issues with stamina calculation

Yeah, SQF doesn't respond well to imaginary numbers.

Implement muscle damage recovery, as it could technically pose a problem, although practically I don't know if it does.

Baer is the go-to for Adv Fatigue but I'm pretty sure that was left out on purpose.

I'm hoping to be able to fix advanced fatigue with high performance factor and recovery factor values, but so far I haven't had any luck in reproducing any errors. Any help is appreciated.

IIRC the issues aren't actually script errors but more just unrecoverable levels of fatigue. I think the best documentation of that we had is gone with Slack now, though.

@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Aug 2, 2023
@PabstMirror PabstMirror merged commit a591aa9 into acemod:master Aug 5, 2023
@johnb432 johnb432 deleted the stamina-fixes branch January 14, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants