Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compats - Remove obsolete repair compat #9267

Closed

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Title.

Requires #8070

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added kind/cleanup Release Notes: **CHANGED:** ignore-changelog Release Notes: Excluded labels Jul 17, 2023
@jonpas
Copy link
Member

jonpas commented Jul 18, 2023

Just merge it into #8070.


class gm_ge_army_shelteraceII_repair_base;
class gm_ge_army_shelteraceII_repair: gm_ge_army_shelteraceII_repair_base {
EGVAR(repair,canRepair) = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these have transportRepair > 0?
because we never zeroed it out
if not then we might want to leave the ace config

transportRepair = 0;
EGVAR(repair,canRepair) = 1;
};

class gm_m113a1dk_medic_base: gm_m113a1dk_base {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class gm_m113a1dk_medic_base: gm_m113a1dk_base {
class gm_m113a1dk_base;
class gm_m113a1dk_medic_base: gm_m113a1dk_base {

@PabstMirror PabstMirror added this to the 3.16.0 milestone Jul 29, 2023
@LinkIsGrim
Copy link
Contributor Author

Integrated into #8070.

@LinkIsGrim LinkIsGrim closed this Jul 29, 2023
@LinkIsGrim LinkIsGrim removed this from the 3.16.0 milestone Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants