New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging - Add limping check to carrier and improve limping check for target unit #9251

Merged

LinkIsGrim merged 2 commits into acemod:master from LinkIsGrim:dragging-add-limp-check

Jul 10, 2023

Contributor

LinkIsGrim commented Jul 10, 2023

When merged this pull request will:

Change the limping damage threshold in FUNC(canCarry) and FUNC(canDrag) to use the actual point at which a unit starts limping.
Add a check for carrier limping FUNC(carryObjectPFH). Previously if the carrier started limping after picking up an object they wouldn't drop it.

IMPORTANT

If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
Development Guidelines are read, understood and applied.
Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

LinkIsGrim added 2 commits

July 10, 2023 06:02


          fix limping damage threshold

5d40012


          add check for carrier not limping

5a14b6e

LinkIsGrim added the kind/enhancement label

PabstMirror approved these changes

View reviewed changes

LinkIsGrim merged commit 535662b into acemod:master

jonpas added this to the 3.16.0 milestone

johnb432 mentioned this pull request

Player frozen when carrying another player and then receiving damage to the legs #7466

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement