Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Rations - Add arsenal category #9221

Merged

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Jun 19, 2023

When merged this pull request will:

  • Title.

Same deal as #9220. This also caches the items in UI namespace in case anyone wants to take a crack at reducing the footprint on fnc_createConsumableChildren and fnc_consumeItem. I tried but I don't want more migraines today.

20230619040919_1

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim
Copy link
Contributor Author

LinkIsGrim commented Jun 19, 2023

Seems to be safe to use configClasses, same items get added to list, but prevents a script error from invalid inherited subclasses.

@LinkIsGrim LinkIsGrim added the kind/feature Release Notes: **ADDED:** label Jun 19, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Jun 28, 2023
@LinkIsGrim LinkIsGrim merged commit 30a0e55 into acemod:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants