-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explosives - Fix incorrect shotParents #9171
Conversation
- Added `setShotParents` to the resulting explosive, enabling support for kill tracking
I think the cmd is server only; may want to use |
Yep, good catch - don't know why that didn't cross my mind. Fixing it shortly. |
Turns out setupExplosive is not the place I want to run I've updated the files accordingly. |
I've moved the |
Doesn't this also make AI magically aware of player's position when setting off the explosive? I remember this being a thing with vanilla touch-off action. |
I will merge as is and then make a follow up PR to control setting shotparents |
When merged this pull request will:
setShotParents
values to explosives created using ACE, enabling support for correct kill counting and damage tracking in external mods/frameworks.IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.