Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionals - Load dynamically based on presence of mod (__has_include) #9116

Merged
merged 21 commits into from
Apr 30, 2023
Merged

Optionals - Load dynamically based on presence of mod (__has_include) #9116

merged 21 commits into from
Apr 30, 2023

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Jan 6, 2023 •
edited
Loading

ref discussion on #8187

pboProject requires a cfgPatch so this adds a dummy one
(does nothing and is named differently so shouldn't cause problems)

https://feedback.bistudio.com/T161113 is still a problem when using file patching but unlikely to cause issues

@PabstMirror PabstMirror added kind/cleanup Release Notes: **CHANGED:** area/tools labels Jan 6, 2023
@PabstMirror PabstMirror changed the title WIP: Optionals - Load dynamically Optionals - Load dynamically based on presence of mod (__has_include) Mar 19, 2023
Dahlgren
Dahlgren reviewed Mar 25, 2023
View reviewed changes
Copy link
Member

@Dahlgren Dahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use versioned actions, the contract has changed between major versions before

jonpas
jonpas requested changes Mar 26, 2023
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it directly-loadable by renaming .hemttout/build to .hemttout/@ace before uploading artifact.

@PabstMirror @jonpas
Apply suggestions from code review
b6ed220 
Co-authored-by: jonpas <jonpas33@gmail.com>
@PabstMirror
Copy link
Contributor Author

artifact doesn't have any bisigns but seems fine otherwise
(compat_ws is not binned but everything else is)

@jonpas
Copy link
Member

jonpas commented Mar 29, 2023

artifact doesn't have any bisigns but seems fine otherwise

hemtt build doesn't sign anything, only hemtt release does.

@PabstMirror PabstMirror mentioned this pull request Apr 30, 2023
Merged
@jonpas jonpas added this to the 3.16.0 milestone Apr 30, 2023
@PabstMirror PabstMirror merged commit fbe23ee into master Apr 30, 2023
@PabstMirror PabstMirror deleted the autoOptionals branch April 30, 2023 21:53
@Superxpdude Superxpdude mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dahlgren Dahlgren Dahlgren left review comments

@BrettMayson BrettMayson BrettMayson left review comments

@veteran29 veteran29 veteran29 approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
area/tools kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@PabstMirror @jonpas @Dahlgren @BrettMayson @veteran29