Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookoff - Move canHaveFireJet logic into vehicle_damage #9060

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Cookoff - Move canHaveFireJet logic into vehicle_damage #9060

merged 3 commits into from
Aug 23, 2023

Conversation

JonBons
Copy link
Contributor

@JonBons JonBons commented Oct 5, 2022

When merged this pull request will:

  • Moves canHaveFireJet logic into vehicle_damage to allow for external calls to cookoff to modify this param bypassing the config check

@JonBons
Moved ace_cookoff_canHaveFireJet config logic into vehicle_damage as …
16b807d 
…a param passed into cookoff to improve modularity
@JonBons JonBons mentioned this pull request Oct 5, 2022
Merged
@PabstMirror PabstMirror added this to the 3.16.0 milestone Aug 22, 2023
@PabstMirror PabstMirror merged commit 2709490 into acemod:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCandianVendingMachine TheCandianVendingMachine TheCandianVendingMachine approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
area/compatibility
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JonBons @TheCandianVendingMachine @PabstMirror