Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather - Add variable to temporarily pause wind simulation #9057

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

OverlordZorn
Copy link
Contributor

@OverlordZorn OverlordZorn commented Oct 3, 2022

This would enable mission maker to temporarily disable the execution of setWind every second. Currently, a temporary pause isnt possible.

When merged this pull request will:

adds a check on GVAR(windSimulation) to allow mission makers to (temporarily) disable Wind Simulation mid mission

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

This would enable mission maker to temporarily disable the execution of setWind every second.
Currently, a temporary pause isnt possible.
@OverlordZorn OverlordZorn changed the title WIP: Weather - Wind Simulation - added exit condition to temporarily pause WIP: Weather - Wind Simulation - added check condition to temporarily pause setWind execution Oct 3, 2022
@OverlordZorn OverlordZorn changed the title WIP: Weather - Wind Simulation - added check condition to temporarily pause setWind execution Weather - Wind Simulation - added check condition to temporarily pause setWind execution Oct 3, 2022
@OverlordZorn OverlordZorn marked this pull request as ready for review October 3, 2022 17:54
Copy link
Member

@BaerMitUmlaut BaerMitUmlaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying a CBA setting at runtime through a script is bad practice and will break with JIPs.

@OverlordZorn
Copy link
Contributor Author

Modifying a CBA setting at runtime through a script is bad practice and will break with JIPs.

if i see it right, this specific script runs only on the server and will be spawned by an PFeh, but its handle isnt saved anywhere.

Is it possible to see a "list" of all currently running perframe-eh-handlers and would there be a way to "find" the right one and removing it temporarily instead?

@johnb432
Copy link
Contributor

if i see it right, this specific script runs only on the server and will be spawned by an PFeh, but its handle isnt saved anywhere.

Is it possible to see a "list" of all currently running perframe-eh-handlers and would there be a way to "find" the right one and removing it temporarily instead?

We are not going to touch the PFH execution array.

However, what can be done more easily (but you'd still need to test it) is to set a "normal" global variable that is publicly available. ace_weather_disableWindSimulation would be my recommended variable name.

@johnb432 johnb432 changed the title Weather - Wind Simulation - added check condition to temporarily pause setWind execution Weather - Add variable to temporarily pause wind simulation Nov 21, 2023
@LinkIsGrim LinkIsGrim added the kind/feature Release Notes: **ADDED:** label Nov 22, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.2 milestone Nov 23, 2023
@LinkIsGrim LinkIsGrim merged commit 65be883 into acemod:master Nov 23, 2023
5 checks passed
@OverlordZorn
Copy link
Contributor Author

only now i saw that this has been addressed and merged, thanks alot! :)

OverlordZorn added a commit to OverlordZorn/STORM-Framework that referenced this pull request Mar 19, 2024
@OverlordZorn OverlordZorn deleted the weather-windsim-exit branch April 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants