Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marker Flags - Add placing system & icons #8951

Merged
merged 11 commits into from
Aug 31, 2022
Merged

Marker Flags - Add placing system & icons #8951

merged 11 commits into from
Aug 31, 2022

Conversation

Timi007
Copy link
Contributor

@Timi007 Timi007 commented Jun 30, 2022

When merged this pull request will:

@Timi007 Timi007 changed the title Marker flags - Add placing system & icons Marker Flags - Add placing system & icons Jun 30, 2022
@Andx667 Andx667 mentioned this pull request Jul 1, 2022
Open
@PabstMirror PabstMirror requested a review from BrettMayson July 23, 2022 15:39
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 23, 2022
@BrettMayson
Copy link
Member

Are we not able to use a single white icon here. and set the color value? Rather than an icon for each color?

@Timi007
Copy link
Contributor Author

Timi007 commented Jul 29, 2022 •
edited
Loading

We could but doesn't look as good. I also wanted it to be consistent with #8943.
Either way the color of the icon also needs to be configured in the config. So you will only remove the *.paa files.

BrettMayson
BrettMayson approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@BrettMayson BrettMayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the icons. Thanks for the contribution!

@BrettMayson BrettMayson added this to the 3.15.1 milestone Aug 31, 2022
@BrettMayson BrettMayson merged commit 11984f6 into acemod:master Aug 31, 2022
@Timi007 Timi007 deleted the marker_flags branch August 31, 2022 18:20
BrettMayson pushed a commit to BrettMayson/ACE3 that referenced this pull request Oct 10, 2022
@Timi007 @BrettMayson
Marker Flags - Add placing system & icons (acemod#8951)
297eaa5
RusComBear pushed a commit to RusComBear/ACE3 that referenced this pull request Dec 29, 2023
@Timi007 @RusComBear
Marker Flags - Add placing system & icons (acemod#8951)
4d61a72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettMayson BrettMayson BrettMayson approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Timi007 @BrettMayson @PabstMirror