Add - Spike LR ATGM #8931
Open
Add - Spike LR ATGM #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
reviewed
Jun 3, 2022
rautamiekka
reviewed
Jun 3, 2022
rautamiekka
reviewed
Jun 3, 2022
rautamiekka
reviewed
Jun 3, 2022
rautamiekka
reviewed
Jun 3, 2022
rautamiekka
reviewed
Jun 3, 2022
rautamiekka
reviewed
Jun 3, 2022
rautamiekka
reviewed
Jun 3, 2022
13 tasks
|
Updated to merge into new missile guidance branch |
|
guess it auto closed because target merged, ugh |
|
reopen test |
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
johnb432
requested changes
Aug 30, 2024
Comment on lines
+18
to
+21
| }/*, { | ||
| params ["_target", "_player", "_params"]; | ||
| // insert children | ||
| }*/] call EFUNC(interact_menu,createAction); |
There was a problem hiding this comment.
This shouldn't stay commented as it is.
|
|
||
| private _lastGroundPos = _cameraNamespace getVariable [QGVAR(lastMovedGroundPos), [0, 0, 0]]; | ||
|
|
||
| if !((_movingCameraX || _movingCameraY) || true) then { |
| _cameraNamespace setVariable [QGVAR(logicPos), _relativePos]; | ||
| _cameraNamespace setVariable [QGVAR(cameraPos), _cameraPosASL]; | ||
|
|
||
| private _p = _cameraPosASL vectorAdd _relativePos; |
There was a problem hiding this comment.
_p should be replaced with a better variable name.
Comment on lines
+35
to
+38
| <English>Designate</English><!-- Check this --> | ||
| </Key> | ||
| <Key ID="STR_ACE_SPIKE_LeaveCamera"> | ||
| <English>Leave Camera</English><!-- Check this --> |
There was a problem hiding this comment.
Comments need to be addressed and removed.
| #include "\z\ace\addons\main\script_mod.hpp" | ||
|
|
||
| // #define DEBUG_MODE_FULL | ||
| #define DISABLE_COMPILE_CACHE |
There was a problem hiding this comment.
Suggested change
| #define DISABLE_COMPILE_CACHE | |
| // #define DISABLE_COMPILE_CACHE |
rautamiekka
suggested changes
Aug 31, 2024
| #include "..\script_component.hpp" | ||
| /* | ||
| * Author: Dani (TCVM) | ||
| * Cycles camera thermal mode (if avaliable) |
There was a problem hiding this comment.
Suggested change
| * Cycles camera thermal mode (if avaliable) | |
| * Cycles camera thermal mode (if available) |
| private _initPosX = (tan _initGimbalAngleX) * GIMBAL_LOGIC_OFFSET; | ||
| private _initPosY = (tan _initGimbalAngleY) * GIMBAL_LOGIC_OFFSET; | ||
|
|
||
| private _projectileBounds = (1 boundingBoxReal _projectile); |
There was a problem hiding this comment.
Suggested change
| private _projectileBounds = (1 boundingBoxReal _projectile); | |
| private _projectileBounds = 1 boundingBoxReal _projectile; |
Comment on lines
+18
to
+20
| params ["_cameraNamespace"]; | ||
|
|
||
| if ([] call FUNC(camera_userInCamera)) exitWith {}; |
There was a problem hiding this comment.
Suggested change
| params ["_cameraNamespace"]; | |
| if ([] call FUNC(camera_userInCamera)) exitWith {}; | |
| if ([] call FUNC(camera_userInCamera)) exitWith {}; | |
| params ["_cameraNamespace"]; |
|
|
||
| private _lastGroundPos = _cameraNamespace getVariable [QGVAR(lastMovedGroundPos), [0, 0, 0]]; | ||
|
|
||
| if !((_movingCameraX || _movingCameraY) || true) then { |
There was a problem hiding this comment.
Suggested change
| if !((_movingCameraX || _movingCameraY) || true) then { | |
| if !(_movingCameraX || _movingCameraY) then { |
| _cameraNamespace setVariable [QGVAR(lastMovedGroundPos), _lastGroundPos]; | ||
| }; | ||
|
|
||
| if (_trackLockedPosition && { (_seekerTargetPos isNotEqualTo [0, 0, 0]) } && _canStopDesignating) then { |
There was a problem hiding this comment.
Suggested change
| if (_trackLockedPosition && { (_seekerTargetPos isNotEqualTo [0, 0, 0]) } && _canStopDesignating) then { | |
| if (_trackLockedPosition && _canStopDesignating && { _seekerTargetPos isNotEqualTo [0, 0, 0] }) then { |
Comment on lines
+18
to
+20
| params [["_cameraNamespace", objNull]]; | ||
|
|
||
| if (isNil QGVAR(activeCamera)) exitWith { false }; |
There was a problem hiding this comment.
Suggested change
| params [["_cameraNamespace", objNull]]; | |
| if (isNil QGVAR(activeCamera)) exitWith { false }; | |
| if (isNil QGVAR(activeCamera)) exitWith { false }; | |
| params [["_cameraNamespace", objNull]]; |
Comment on lines
+18
to
+20
| params ["_key", "_down"]; | ||
|
|
||
| if ((currentWeapon ACE_player) != QGVAR(launcher)) exitWith {}; |
There was a problem hiding this comment.
Suggested change
| params ["_key", "_down"]; | |
| if ((currentWeapon ACE_player) != QGVAR(launcher)) exitWith {}; | |
| if ((currentWeapon ACE_player) != QGVAR(launcher)) exitWith {}; | |
| params ["_key", "_down"]; |
| if ((currentWeapon ACE_player) != QGVAR(launcher)) exitWith {}; | ||
|
|
||
| if (_key == SPIKE_KEY_DESIGNATE) then { | ||
| if (cameraView == "GUNNER") then { |
There was a problem hiding this comment.
Suggested change
| if (cameraView == "GUNNER") then { | |
| if (cameraView isEqualTo "GUNNER") then { |
Comment on lines
+40
to
+51
| _cameraArray set [9, [ | ||
| getNumber (_cameraConfig >> "gimbal" >> "enabled") == 1, | ||
| getNumber (_cameraConfig >> "gimbal" >> "gimbalAngleX"), | ||
| getNumber (_cameraConfig >> "gimbal" >> "gimbalAngleY"), | ||
| getNumber (_cameraConfig >> "gimbal" >> "gimbalSpeedX"), | ||
| getNumber (_cameraConfig >> "gimbal" >> "gimbalSpeedY"), | ||
| getNumber (_cameraConfig >> "gimbal" >> "gimbalInitOffsetX"), | ||
| getNumber (_cameraConfig >> "gimbal" >> "gimbalInitOffsetY"), | ||
| getArray (_cameraConfig >> "gimbal" >> "fovGimbalSpeedModifiers"), | ||
| getNumber (_cameraConfig >> "gimbal" >> "stabilizeWhenMoving") == 1, | ||
| getNumber (_cameraConfig >> "gimbal" >> "designateWhenStationary") == 1, | ||
| getNumber (_cameraConfig >> "gimbal" >> "trackLockedPosition") == 1 |
There was a problem hiding this comment.
Ouch, this many calls has to be expensive.
Suggested change
| _cameraArray set [9, [ | |
| getNumber (_cameraConfig >> "gimbal" >> "enabled") == 1, | |
| getNumber (_cameraConfig >> "gimbal" >> "gimbalAngleX"), | |
| getNumber (_cameraConfig >> "gimbal" >> "gimbalAngleY"), | |
| getNumber (_cameraConfig >> "gimbal" >> "gimbalSpeedX"), | |
| getNumber (_cameraConfig >> "gimbal" >> "gimbalSpeedY"), | |
| getNumber (_cameraConfig >> "gimbal" >> "gimbalInitOffsetX"), | |
| getNumber (_cameraConfig >> "gimbal" >> "gimbalInitOffsetY"), | |
| getArray (_cameraConfig >> "gimbal" >> "fovGimbalSpeedModifiers"), | |
| getNumber (_cameraConfig >> "gimbal" >> "stabilizeWhenMoving") == 1, | |
| getNumber (_cameraConfig >> "gimbal" >> "designateWhenStationary") == 1, | |
| getNumber (_cameraConfig >> "gimbal" >> "trackLockedPosition") == 1 | |
| private _cameraConfigGimbal = _cameraConfig >> "gimbal"; | |
| _cameraArray set [9, [ | |
| getNumber (_cameraConfigGimbal >> "enabled") == 1, | |
| getNumber (_cameraConfigGimbal >> "gimbalAngleX"), | |
| getNumber (_cameraConfigGimbal >> "gimbalAngleY"), | |
| getNumber (_cameraConfigGimbal >> "gimbalSpeedX"), | |
| getNumber (_cameraConfigGimbal >> "gimbalSpeedY"), | |
| getNumber (_cameraConfigGimbal >> "gimbalInitOffsetX"), | |
| getNumber (_cameraConfigGimbal >> "gimbalInitOffsetY"), | |
| getArray (_cameraConfigGimbal >> "fovGimbalSpeedModifiers"), | |
| getNumber (_cameraConfigGimbal >> "stabilizeWhenMoving") == 1, | |
| getNumber (_cameraConfigGimbal >> "designateWhenStationary") == 1, | |
| getNumber (_cameraConfigGimbal >> "trackLockedPosition") == 1 |
Comment on lines
+54
to
+64
| _cameraArray set [10, [ | ||
| getText (_cameraConfig >> "reticle" >> "titleRsc"), | ||
| getNumber (_cameraConfig >> "reticle" >> "centerReticle"), | ||
| getArray (_cameraConfig >> "reticle" >> "controlsToDisappearOnLock"), | ||
| getArray (_cameraConfig >> "reticle" >> "controlsToAppearOnLock"), | ||
| getNumber (_cameraConfig >> "reticle" >> "leftGate"), | ||
| getNumber (_cameraConfig >> "reticle" >> "rightGate"), | ||
| getNumber (_cameraConfig >> "reticle" >> "topGate"), | ||
| getNumber (_cameraConfig >> "reticle" >> "bottomGate"), | ||
| getText (_cameraConfig >> "reticle" >> "uiNamespaceDialogVariable"), | ||
| getNumber (_cameraConfig >> "reticle" >> "reticleMovesWithTrack") == 1 |
There was a problem hiding this comment.
Suggested change
| _cameraArray set [10, [ | |
| getText (_cameraConfig >> "reticle" >> "titleRsc"), | |
| getNumber (_cameraConfig >> "reticle" >> "centerReticle"), | |
| getArray (_cameraConfig >> "reticle" >> "controlsToDisappearOnLock"), | |
| getArray (_cameraConfig >> "reticle" >> "controlsToAppearOnLock"), | |
| getNumber (_cameraConfig >> "reticle" >> "leftGate"), | |
| getNumber (_cameraConfig >> "reticle" >> "rightGate"), | |
| getNumber (_cameraConfig >> "reticle" >> "topGate"), | |
| getNumber (_cameraConfig >> "reticle" >> "bottomGate"), | |
| getText (_cameraConfig >> "reticle" >> "uiNamespaceDialogVariable"), | |
| getNumber (_cameraConfig >> "reticle" >> "reticleMovesWithTrack") == 1 | |
| private _cameraConfigReticle = _cameraConfig >> "reticle"; | |
| _cameraArray set [10, [ | |
| getText (_cameraConfigReticle >> "titleRsc"), | |
| getNumber (_cameraConfigReticle >> "centerReticle"), | |
| getArray (_cameraConfigReticle >> "controlsToDisappearOnLock"), | |
| getArray (_cameraConfigReticle >> "controlsToAppearOnLock"), | |
| getNumber (_cameraConfigReticle >> "leftGate"), | |
| getNumber (_cameraConfigReticle >> "rightGate"), | |
| getNumber (_cameraConfigReticle >> "topGate"), | |
| getNumber (_cameraConfigReticle >> "bottomGate"), | |
| getText (_cameraConfigReticle >> "uiNamespaceDialogVariable"), | |
| getNumber (_cameraConfigReticle >> "reticleMovesWithTrack") == 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Requires #10019