Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casings - Add infantry bullet casings #8857

Merged
merged 28 commits into from
May 8, 2022

Conversation

Cyruz143
Copy link
Contributor

@Cyruz143 Cyruz143 commented Mar 22, 2022

When merged this pull request will:

  • It's a stripped down and basic version of (Port of ACE2 casings #4132).
  • Only impacts infantry weapons, no vehicles etc
  • Fully local, no network sync
  • Has some settings (on/off, maximum amount of brass)

I've been using a version of this since 2020. It works fairly well, will have odd floating cases, especially near the edges of objects and buildings etc. I've taken most of the vector bits from the original PR, math could probably be better if anyone wants to have a go!

I've left esteldunedain in the authors as I'm using parts of his original code. Also @diwako helped me with this a while ago, happy to add you on to this too bud!

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Mar 22, 2022
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and neat.

@jonpas jonpas added this to the 3.14.2 milestone Apr 4, 2022
Removed unused param

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@Cyruz143
Copy link
Contributor Author

Cyruz143 commented Apr 10, 2022

After many discussions in dev on Slack. I've switched it to use an LIS check. Because of the performance concerns, especially for something visual, I've disabled it by default.

@netlify
Copy link

netlify bot commented Apr 20, 2022

Deploy Preview for splendid-khapse-142a9c ready!

Name Link
🔨 Latest commit 74303b5
🔍 Latest deploy log https://app.netlify.com/sites/splendid-khapse-142a9c/deploys/625fe88dbb31c700084a69c3
😎 Deploy Preview https://deploy-preview-8857--splendid-khapse-142a9c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Cyruz143
Copy link
Contributor Author

Ran this PR'd version through a session and got a few people of varying hardware specs to enable it. Even during some fairly big fire fights, no-one noticed any performance impact (as I was asking them to keep an eye on stuttering/fps etc). Obviously the arma butt dyno isn't the best performance metric but it's better than nothing!

@jonpas
Copy link
Member

jonpas commented May 4, 2022

I think this should be enabled by default. :)

@veteran29 veteran29 self-requested a review May 5, 2022 09:49
@PabstMirror
Copy link
Contributor

20220505114451_1

Bullets seem to be halfway underground
I think because it's a simple object it's placed via https://community.bistudio.com/wiki/setPosWorld (model center)
So I guess we might want to add the radius of the case to the z height (probably 4-5mm)
But it's not a big deal

Cyruz143 and others added 5 commits May 5, 2022 18:23
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror merged commit 3ddec6c into acemod:master May 8, 2022
@Cyruz143 Cyruz143 mentioned this pull request May 8, 2022
1 task
@Cyruz143 Cyruz143 deleted the simplified_casings branch May 18, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants