-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casings - Add infantry bullet casings #8857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short and neat.
Removed unused param Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
After many discussions in dev on Slack. I've switched it to use an LIS check. Because of the performance concerns, especially for something visual, I've disabled it by default. |
✅ Deploy Preview for splendid-khapse-142a9c ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ran this PR'd version through a session and got a few people of varying hardware specs to enable it. Even during some fairly big fire fights, no-one noticed any performance impact (as I was asking them to keep an eye on stuttering/fps etc). Obviously the arma butt dyno isn't the best performance metric but it's better than nothing! |
I think this should be enabled by default. :) |
Bullets seem to be halfway underground |
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
When merged this pull request will:
I've been using a version of this since 2020. It works fairly well, will have odd floating cases, especially near the edges of objects and buildings etc. I've taken most of the vector bits from the original PR, math could probably be better if anyone wants to have a go!
I've left esteldunedain in the authors as I'm using parts of his original code. Also @diwako helped me with this a while ago, happy to add you on to this too bud!
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.