Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tagging - Allow tagging vehicles (overwrite "clan" tag) #8852

Merged
merged 6 commits into from
Sep 4, 2022
Merged

Tagging - Allow tagging vehicles (overwrite "clan" tag) #8852

merged 6 commits into from
Sep 4, 2022

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Mar 20, 2022 •
edited
Loading

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Mar 20, 2022
@PabstMirror PabstMirror added this to the Backlog milestone Mar 20, 2022
PabstMirror and others added 2 commits April 8, 2022 17:52
@PabstMirror @neilzar
Update addons/tagging/functions/fnc_createTag.sqf
5efe7fd 
Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>
@PabstMirror
fix var
00f9dd8
@PabstMirror PabstMirror changed the title WIP - Tagging - Allow tagging vehicles (overwrite "clan" tag, req 2.10) Tagging - Allow tagging vehicles (overwrite "clan" tag) Aug 28, 2022
@PabstMirror PabstMirror marked this pull request as ready for review August 28, 2022 23:06
@PabstMirror PabstMirror modified the milestones: Backlog, 3.15.1 Aug 28, 2022
@PabstMirror
Copy link
Contributor Author

uses same system as #9018 but I don't think they conflict

BrettMayson
BrettMayson approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@BrettMayson BrettMayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does work fine on vehicles that support it. Does feel a little weird to me that it also works on vehicles without a selection for a clan tag, and that it uses self-interaction instead of the vehicle's interaction point.

@PabstMirror
Copy link
Contributor Author

Added filter for vehicles without a valid selection

veteran29
veteran29 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabstMirror PabstMirror merged commit a339074 into master Sep 4, 2022
@PabstMirror PabstMirror deleted the tagb branch September 4, 2022 21:38
BrettMayson pushed a commit to BrettMayson/ACE3 that referenced this pull request Oct 10, 2022
@PabstMirror @neilzar @BrettMayson
Tagging - Allow tagging vehicles (overwrite "clan" tag) (acemod#8852)
0150e5d 
* Tagging - Allow tagging vehicles (overwrite "clan" tag, req 2.10)

* Update addons/tagging/functions/fnc_createTag.sqf

Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>

* fix var

* set REQUIRED_VERSION to 2.10

* don't tag if veh has no valid selectionClan

Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>
RusComBear pushed a commit to RusComBear/ACE3 that referenced this pull request Dec 29, 2023
@PabstMirror @neilzar @RusComBear
Tagging - Allow tagging vehicles (overwrite "clan" tag) (acemod#8852)
b27876f 
* Tagging - Allow tagging vehicles (overwrite "clan" tag, req 2.10)

* Update addons/tagging/functions/fnc_createTag.sqf

Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>

* fix var

* set REQUIRED_VERSION to 2.10

* don't tag if veh has no valid selectionClan

Co-authored-by: Neil Evers <neil.evers.1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilzar neilzar neilzar left review comments

@veteran29 veteran29 veteran29 approved these changes

@BrettMayson BrettMayson BrettMayson approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.15.1
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @neilzar @BrettMayson @veteran29